Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Sync, Beta to Stable #1090

Merged
merged 14 commits into from
Apr 6, 2023
Merged

Environment Sync, Beta to Stable #1090

merged 14 commits into from
Apr 6, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 4, 2023 •
edited
Loading

What's included

Notes

  • minor updates, also includes page title adjustments

Commits

Features

Code Refactoring

Chores

  • deps-dev npm-check-updates from 16.7.10 to 16.10.0 (#1088) (8f1031f)
  • deps-dev @babel/core from 7.21.0 to 7.21.3 (#1087) (da651f8)
  • deps-dev eslint from 8.34.0 to 8.36.0 (#1084) (638f140)
  • deps-dev bump jest from 29.4.3 to 29.5.0 (#1078) (e0ed6cb)
  • deps-dev bump eslint-config-prettier from 8.6.0 to 8.7.0 (#1076) (a4f3cee)

Bug Fixes

dependabot bot and others added 13 commits March 21, 2023 09:37
@dependabot @cdcabrera
chore(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 (#1076)
a4f3cee
@cdcabrera
refactor(graphCard): sw-923 allow nested graph configs (#1073)
82aae99 
* config, products, isMetricDisplay, nested chart groups
* graphCard, isMetricDisplay setting
* graphCardChart, remove isStandalone, useProduct hook
* graphCardChartTitleTooltip, stringId, remove hook
* graphCardContext, return single list of settings
* graphCardHelpers, restructure for nested chart groups
* graphCardMetricTotals, alias id to chartId
* productViewContext, uom filter on nested chart groups
* styling, adjust grouped chart margins
* toolbarFieldCategory, generate opts, chart groups
@dependabot @cdcabrera
chore(deps-dev): bump jest from 29.4.3 to 29.5.0 (#1078)
e0ed6cb
@cdcabrera
refactor(i18nHelpers): sw-922 translate break apart, testing (#1079)
617d1a5 
* helpers, move noopTranslate
* i18nHelpers, break apart for testing, noopTranslate
@cdcabrera
feat(i18nHelpers): sw-922 apply testId to copy (#1079)
2c456e8
@cdcabrera
fix(i18nHelpers): sw-922 i18n element wrapping (#1080)
a242cbc
@cdcabrera
feat(config): sw-922 product custom card metrics (#1077)
c979301 
* config, rhacs, rhods, rhosak, card metrics to display
* helpers, setImmutableData
* graphCard, move isMetricDisplay check to totals comp
* graphCardHelpers, set, or determine, isMetricDisplay
* graphCardMetricTotals, passthrough, call card callbacks
* pageColumns, adjust children isRequired
@cdcabrera
fix(build): npm updates (#1081)
1844103
@dependabot
chore(deps-dev): eslint from 8.34.0 to 8.36.0 (#1084)
638f140
@cdcabrera
fix(chartHelpers): sw-1030 expand x axis unit test (#1082)
1d41724
@dependabot
chore(deps-dev): @babel/core from 7.21.0 to 7.21.3 (#1087)
da651f8
@dependabot
chore(deps-dev): npm-check-updates from 16.7.10 to 16.10.0 (#1088)
8f1031f
@cdcabrera
fix(routerContext): sw-1089 page display titles (#1089)
3c4de82
@cdcabrera cdcabrera added the 202304 project phase label Apr 4, 2023
@cdcabrera cdcabrera marked this pull request as ready for review April 4, 2023 16:32
@cdcabrera
feat(routerContext): sw-1089 enhance page titles (#1091)
939fd1d 
* routerContext, exposed bundleTitle through useChrome
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #1090 (939fd1d) into main (783ad62) will increase coverage by 0.10%.
The diff coverage is 93.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   93.49%   93.59%   +0.10%     
==========================================
  Files         123      121       -2     
  Lines        4134     4216      +82     
  Branches     1680     1705      +25     
==========================================
+ Hits         3865     3946      +81     
- Misses        251      253       +2     
+ Partials       18       17       -1
Impacted Files Coverage Δ
src/components/pageLayout/pageColumns.js 100.00% <ø> (ø)
src/config/product.openshiftContainer.js 80.95% <ø> (ø)
src/config/product.openshiftDedicated.js 80.76% <ø> (ø)
src/config/product.rhel.js 90.69% <ø> (ø)
src/config/product.satellite.js 94.11% <ø> (ø)
src/config/product.rhacs.js 85.71% <85.71%> (ø)
src/config/product.rhods.js 85.71% <85.71%> (ø)
src/config/product.rhosak.js 84.21% <85.71%> (+0.48%) ⬆️
src/components/i18n/i18nHelpers.js 93.54% <92.77%> (+5.45%) ⬆️
src/common/helpers.js 100.00% <100.00%> (ø)
... and 9 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ad62...939fd1d. Read the comment docs.

@cdcabrera cdcabrera merged commit 1d05b6d into main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202304 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter