feat(config): sw-922 product custom card metrics #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
commented
Mar 9, 2023
cdcabrera
commented
Mar 9, 2023
src/components/graphCard/__tests__/__snapshots__/graphCardMetricTotals.test.js.snap
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1077 +/- ##
==========================================
+ Coverage 93.50% 93.57% +0.06%
==========================================
Files 123 121 -2
Lines 4128 4155 +27
Branches 1681 1686 +5
==========================================
+ Hits 3860 3888 +28
+ Misses 250 249 -1
Partials 18 18
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cdcabrera
force-pushed
the
sw-922
branch
2 times, most recently
from
5514192 to
a9833ea
Compare
|
/retest |
cdcabrera
force-pushed
the
sw-922
branch
2 times, most recently
from
528b1a3 to
5ac84af
Compare
* config, rhacs, rhods, rhosak, card metrics to display * helpers, setImmutableData * graphCard, move isMetricDisplay check to totals comp * graphCardHelpers, set, or determine, isMetricDisplay * graphCardMetricTotals, passthrough, call card callbacks * pageColumns, adjust children isRequired
cdcabrera
changed the title
cdcabrera
added a commit
that referenced
this pull request
Mar 21, 2023
* config, rhacs, rhods, rhosak, card metrics to display * helpers, setImmutableData * graphCard, move isMetricDisplay check to totals comp * graphCardHelpers, set, or determine, isMetricDisplay * graphCardMetricTotals, passthrough, call card callbacks * pageColumns, adjust children isRequired
cdcabrera
added a commit
that referenced
this pull request
Apr 6, 2023
* config, rhacs, rhods, rhosak, card metrics to display * helpers, setImmutableData * graphCard, move isMetricDisplay check to totals comp * graphCardHelpers, set, or determine, isMetricDisplay * graphCardMetricTotals, passthrough, call card callbacks * pageColumns, adjust children isRequired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
testIds against locale strings... RHOSAK/streams, RHODS, RHACS now use the following identifiers against datagraphDailyTotalCard-header(description area)graphDailyTotalCard-body(numeric/total area)graphDailyTotalCard-footer(date area)graphMonthlyTotalCard-header(description area)graphMonthlyTotalCard-body(numeric/total area)graphMonthlyTotalCard-footer(date area)How to test
Coverage and basic unit test check
$ yarn$ yarn testProxy run check
$ yarn$ yarn start:proxyExample
...
Updates issue/story
sw-922 sw-923