Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-1695 activate rhel for sap x86 #1200

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 26, 2023

What's included

  • feat(config): sw-1695 activate rhel for sap x86

Notes

  • Sorting automatically makes SAP x86 appear first in the list
    • Any additional name extensions with also appear first, ie. EUS x86
    • "Human based sorting" will require additional modification

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the product
    • appears in the variant list for RHEL
    • confirm ALL API calls now include the product ID rhel-for-x86-sap

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2023-09-26 at 1 16 55 PM

Updates issue/story

sw-1695

@cdcabrera cdcabrera added the 202312 project phase label Sep 26, 2023
@cdcabrera cdcabrera merged commit 6103f91 into RedHatInsights:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202312 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant