Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-1695 update sap x86 #1201

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 26, 2023

What's included

  • fix(config): sw-1695 update sap x86

Notes

  • the OG issue had an inaccurate product id, this corrects it
  • this will be squashed into the prior work

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

#1200
sw-1695

@cdcabrera cdcabrera added bug Something isn't working 202312 project phase labels Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #1201 (f8f09ca) into main (6103f91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         121      121           
  Lines        4188     4188           
  Branches     1751     1751           
=======================================
  Hits         3870     3870           
  Misses        299      299           
  Partials       19       19           
Files Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6103f91...f8f09ca. Read the comment docs.

@cdcabrera cdcabrera merged commit 18c2d0f into RedHatInsights:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202312 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants