-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pageHeader): issues/305 add bottom margin to h1 #357
Conversation
Codecov Report
@@ Coverage Diff @@
## ci #357 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 61 61
Lines 1476 1476
Branches 349 349
=======================================
Hits 1364 1364
Misses 98 98
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we missed the inline-block
... trying not to totally remove the inline
quality from the H1, not clear why it's like that
6e3e429
to
2de61db
Compare
2de61db
to
0fa9a55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* build, platform package update for h1 * pageHeader, pf class added * style, file names for consistency
* build, platform package update for h1 * pageHeader, pf class added * style, file names for consistency
* build, platform package update for h1 * pageHeader, pf class added * style, file names for consistency
* build, platform package update for h1 * pageHeader, pf class added * style, file names for consistency
What's included
How to test
Local run check
$ yarn
$ yarn start
Example
Before
After
Updates issue/story
Fixes pull request #348
Helps resolve issue #305