New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toolbar): issues/10 add usage filter #361

Merged

cdcabrera merged 2 commits into RedHatInsights:ci from cdcabrera:issues/10-usage-filter

Aug 4, 2020

Member

cdcabrera commented Jul 31, 2020 •

edited

Loading

What's included

feat(toolbar): issues/10 add usage filter
- i18n, locale strings for usage
- toolbar, toolbarTypes, add usage filter
- redux, middleware, multiActionMiddleware, add array of actions
- redux, reducers, types, toolbar addtions
- styles, add toolbar styles
fix(queryTypes): issues/10 rhsm to query type
- graphCard, c3graphCard, filter to query name
- queryTypes, rhsmTypes, filter to query, align naming
- toolbar, apply query SLA type
- viewReducer, apply query types

Notes

incremental feature update, usage filter

How to test

Proxy run check

update the NPM packages with $ yarn
make sure Docker is running, plus on network, then
$ yarn start:proxy
confirm the new usage toolbar dropdown filter accurately updates the related AJAX/XHR calls for graphCard
- dev browser console can be used

Example

Updates issue/story

Updates #10

cdcabrera mentioned this pull request

Development for an inventory listing #10

Closed

10 tasks

cdcabrera force-pushed the issues/10-usage-filter branch from 4c94943 to 97a2973 Compare

July 31, 2020 21:17

cdcabrera force-pushed the ci branch from 41018b7 to d20307b Compare

July 31, 2020 23:23

cdcabrera force-pushed the issues/10-usage-filter branch from 97a2973 to 78a98c9 Compare

August 4, 2020 16:40

cdcabrera changed the title ~~WIP feat(toolbar): issues/10 add usage filter~~ feat(toolbar): issues/10 add usage filter

codecov-commenter commented Aug 4, 2020 •

edited

Loading

Codecov Report

Merging #361 into ci will decrease coverage by 0.00%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##               ci     #361      +/-   ##
==========================================
- Coverage   92.44%   92.43%   -0.01%     
==========================================
  Files          61       64       +3     
  Lines        1483     1521      +38     
  Branches      348      353       +5     
==========================================
+ Hits         1371     1406      +35     
- Misses         98      100       +2     
- Partials       14       15       +1

Impacted Files	Coverage Δ
src/components/c3GraphCard/c3GraphCard.js	`88.67% <ø> (ø)`
src/components/graphCard/graphCard.js	`83.67% <ø> (ø)`
src/redux/reducers/viewReducer.js	`100.00% <ø> (ø)`
src/redux/types/index.js	`100.00% <ø> (ø)`
src/redux/types/rhsmTypes.js	`100.00% <ø> (ø)`
src/components/toolbar/toolbar.js	`91.48% <92.10%> (-3.75%)`	⬇️
src/components/toolbar/toolbarTypes.js	`100.00% <100.00%> (ø)`
src/redux/reducers/toolbarReducer.js	`100.00% <100.00%> (ø)`
src/redux/types/queryTypes.js	`100.00% <100.00%> (ø)`
src/redux/types/toolbarTypes.js	`100.00% <100.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5874d...0bfbaad. Read the comment docs.

cdcabrera force-pushed the issues/10-usage-filter branch 2 times, most recently from 8eb301c to 23a377f Compare

August 4, 2020 18:20

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request


          fix(redux): issues/10 expand rhsmTypes for filtering (RedHatInsights#361

65f56db

)

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request


          feat(toolbar): issues/10 add usage filter (RedHatInsights#361)

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

cdcabrera force-pushed the issues/10-usage-filter branch from 23a377f to 8356231 Compare

August 4, 2020 18:26


          fix(queryTypes): issues/10 rhsm to query type (RedHatInsights#361)

916312c

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request


          feat(toolbar): issues/10 add usage filter (RedHatInsights#361)

0bfbaad

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

cdcabrera force-pushed the issues/10-usage-filter branch from 8356231 to 0bfbaad Compare

August 4, 2020 18:30

cdcabrera commented

View reviewed changes

src/redux/reducers/toolbarReducer.js Outdated Show resolved Hide resolved


          feat(toolbar): issues/10 add usage filter (RedHatInsights#361)

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

cdcabrera force-pushed the issues/10-usage-filter branch from 0bfbaad to 0004847 Compare

August 4, 2020 19:28

cdcabrera merged commit b14aaf2 into RedHatInsights:ci

cdcabrera added a commit that referenced this pull request


          fix(queryTypes): issues/10 rhsm to query type (#361)

861ccb2

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera mentioned this pull request

Environment Sync, Dev to Test #362

Merged

cdcabrera added a commit that referenced this pull request


          fix(queryTypes): issues/10 rhsm to query type (#361)

89b2588

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera added a commit that referenced this pull request


          feat(toolbar): issues/10 add usage filter (#361)

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

cdcabrera mentioned this pull request

Draft release 0.1.19, Sync Test to Stage #376

Merged

cdcabrera added a commit that referenced this pull request


          fix(queryTypes): issues/10 rhsm to query type (#361)

d12b624

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera added a commit that referenced this pull request


          feat(toolbar): issues/10 add usage filter (#361)

f7b357d

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

cdcabrera mentioned this pull request

Production Increment 0.1.19 #387

Merged

cdcabrera added a commit that referenced this pull request


          fix(queryTypes): issues/10 rhsm to query type (#361)

1070ac2

* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types

cdcabrera added a commit that referenced this pull request


          feat(toolbar): issues/10 add usage filter (#361)

9ad7dcb

* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet