Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbar): issues/10 default usage filter category #368

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 5, 2020

What's included

fix(toolbar): issues/10 default usage filter category

  • toolbar, default filter category, soft filter reset

Notes

  • Toolbar filters start the initial view with the "usage" category selected
  • "Clearing all" filters leaves the last selected category visually active
  • The default category can be easily updated in the future

@rblackbu

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. observe the initial starting filter category is usage, see attached screenshot

Example

Screen Shot 2020-08-05 at 10 48 41 AM

Aug-05-2020 10-53-23

Updates issue/story

Updates #10

* toolbar, default filter category, soft filter reset
@cdcabrera cdcabrera requested a review from bclarhk August 5, 2020 14:50
@cdcabrera cdcabrera mentioned this pull request Aug 5, 2020
10 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #368 into ci will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #368      +/-   ##
==========================================
+ Coverage   92.43%   92.47%   +0.03%     
==========================================
  Files          64       64              
  Lines        1521     1528       +7     
  Branches      353      355       +2     
==========================================
+ Hits         1406     1413       +7     
  Misses        100      100              
  Partials       15       15              
Impacted Files Coverage Δ
src/components/toolbar/toolbar.js 92.59% <100.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2e1e0...80a7396. Read the comment docs.

@cdcabrera cdcabrera merged commit 87f736a into RedHatInsights:ci Aug 5, 2020
@bclarhk
Copy link

bclarhk commented Aug 5, 2020

LGTM!

cdcabrera added a commit that referenced this pull request Aug 6, 2020
* toolbar, default filter category, soft filter reset
cdcabrera added a commit that referenced this pull request Aug 17, 2020
* toolbar, default filter category, soft filter reset
cdcabrera added a commit that referenced this pull request Aug 24, 2020
* toolbar, default filter category, soft filter reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants