fix(toolbar): issues/377 openshiftView, remove usage filter #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As of 20200813 unit tests, snapshots, |
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Aug 13, 2020
…sights#378) * graphCard,c3GraphCard, switch redux granularity type * locale, i18n, switch toolbar strings to context * openshiftView, rhelView, apply filters for toolbar * redux, queryTypes, viewReducer, granularity, sla, usage types * toolbar, convert to config based filter display * toolbarTypes, use context for locale strings
cdcabrera
changed the title
cdcabrera
commented
Aug 13, 2020
…sights#378) * graphCard,c3GraphCard, switch redux granularity type * locale, i18n, switch toolbar strings to context * openshiftView, rhelView, apply filters for toolbar * redux, queryTypes, viewReducer, granularity, sla, usage types * toolbar, convert to config based filter display * toolbarTypes, use context for locale strings
Codecov Report
@@ Coverage Diff @@
## qa #378 +/- ##
==========================================
- Coverage 92.47% 92.40% -0.07%
==========================================
Files 64 64
Lines 1528 1528
Branches 355 355
==========================================
- Hits 1413 1412 -1
- Misses 100 101 +1
Partials 15 15
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Aug 17, 2020
* graphCard,c3GraphCard, switch redux granularity type * locale, i18n, switch toolbar strings to context * openshiftView, rhelView, apply filters for toolbar * redux, queryTypes, viewReducer, granularity, sla, usage types * toolbar, convert to config based filter display * toolbarTypes, use context for locale strings
cdcabrera
added a commit
that referenced
this pull request
Aug 24, 2020
* graphCard,c3GraphCard, switch redux granularity type * locale, i18n, switch toolbar strings to context * openshiftView, rhelView, apply filters for toolbar * redux, queryTypes, viewReducer, granularity, sla, usage types * toolbar, convert to config based filter display * toolbarTypes, use context for locale strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Local run check
$ yarn$ yarn starthttp://localhost:3000/rhel-sw/alland observe that both the SLA and Usage filter types are available.http://localhost:3000/openshift-sw/and observe that ONLY the SLA filter type is availableExample
RHEL view
OpenShift view
Updates issue/story
Updates #377
Unblocks #376
Relates #10