Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #420

Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix(build): npm updates #420

merged 1 commit into from
Sep 11, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): npm updates
    • lint, jsdoc settings
    • router, snapshot tests
    • chartArea, rhsmServices, jsdoc format
    • platform, pf based updates
    • testing, platform implementation test expanded

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. no errors should be present

Example

...

Updates issue/story

Ongoing

* lint, jsdoc settings
* router, snapshot tests
* chartArea, rhsmServices, jsdoc format
* platform, pf based updates
* testing, platform implementation test expanded
@codecov-commenter
Copy link

Codecov Report

Merging #420 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #420   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          70       70           
  Lines        1715     1715           
  Branches      394      394           
=======================================
  Hits         1591     1591           
  Misses        109      109           
  Partials       15       15           
Impacted Files Coverage Δ
src/components/chartArea/chartArea.js 87.77% <ø> (ø)
src/redux/actions/platformActions.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92617d7...97d30e5. Read the comment docs.

@cdcabrera cdcabrera merged commit c3dc817 into RedHatInsights:ci Sep 11, 2020
cdcabrera added a commit that referenced this pull request Sep 11, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
cdcabrera added a commit that referenced this pull request Sep 16, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
cdcabrera added a commit that referenced this pull request Oct 8, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
cdcabrera added a commit that referenced this pull request Oct 14, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
cdcabrera added a commit that referenced this pull request Oct 26, 2020
* linting config, chartArea, rhsmServices, jsdoc formating
* testing, router, platform component check test expanded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants