Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): activate GitHub workflow for PRs #427

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 17, 2020

What's included

  • chore(build): activate GitHub workflow for PRs

Notes

  • Once this is merged it is important that we disable the "pull request" Travis checks. If we need to back this workflow out we can simply reactivate the Travis "pull request" check and remove the workflow
    • Possible, appears we may need to leave the "pull request" Travis check running until this change is merged all the way up. However, we can make Travis "NOT required" on any branch where the GitHub workflow is. Travis will run, just as an add on until it can be worked completely out.

Why?

Running unit tests in Travis seems to be getting increasingly slower with each new test. This is an attempt to remove Pull Requests from Travis and move those confirmations into GitHub.

We will still be using the same Travis scripts to compile the GUI, and push to the curiosity-frontend-build repo, which in turn pushes to the Platform environments. This includes the exact same scripts as the GitHub workflow... Travis is just slower

How to test

Once this is merged

  1. rebase your PR against the CI branch
  2. open a PR against CI, there should be a "checks" tab on GitHub PRs
    Screen Shot 2020-09-16 at 10 22 31 PM
  3. the new workflow should be visible as "Pull request"

Example

...

Updates issue/story

Ongoing and #275
PRs - #436 #435 #434

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #427 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #427   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          69       69           
  Lines        1716     1716           
  Branches      392      392           
=======================================
  Hits         1591     1591           
  Misses        110      110           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d9cd...321a668. Read the comment docs.

* pull_request, GitHub pull request workflow
* custom_release, Travis expand branches allowed for prod-stable
@cdcabrera cdcabrera merged commit f7da959 into RedHatInsights:ci Sep 17, 2020
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* pull_request, GitHub workflow, error annotations, cache
* custom_release, Travis expand branches allowed for prod-stable
cdcabrera added a commit that referenced this pull request Oct 8, 2020
* pull_request, GitHub workflow, error annotations, cache
* custom_release, Travis expand branches allowed for prod-stable
cdcabrera added a commit that referenced this pull request Oct 14, 2020
* pull_request, GitHub workflow, error annotations, cache
* custom_release, Travis expand branches allowed for prod-stable
cdcabrera added a commit that referenced this pull request Oct 26, 2020
* pull_request, GitHub workflow, error annotations, cache
* custom_release, Travis expand branches allowed for prod-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants