Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inventoryList,guestsList): issues/494 fixed column widths #472

Merged
merged 1 commit into from
Nov 6, 2020
Merged

feat(inventoryList,guestsList): issues/494 fixed column widths #472

merged 1 commit into from
Nov 6, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 23, 2020 •
edited
Loading

What's included

  • feat(inventoryList,guestsList): issues/494 fixed column widths

Notes

  • Adds the ability to set fixed inventory column widths through config
    • Even though we're applying column widths there is still a potential shift in inventory paged displays that have/do not have expandable sections. The Patternfly expandable table rows add an additional table column that shift the view.
  • Table skeleton should have fixed column widths applied too
  • inventoryListHelpers changes are prep for Update the Sockets column header copy #483

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm during paging of the inventory display that columns maintain their width in a consistent manner.

Example

Screen Shot 2020-11-05 at 3 59 47 PM

Screen Shot 2020-11-06 at 12 22 01 PM

Updates issue/story

#494
relates #483

@cdcabrera cdcabrera force-pushed the ci branch 2 times, most recently from 30e5210 to a25677d Compare October 27, 2020 01:49
@cdcabrera cdcabrera mentioned this pull request Oct 28, 2020
Closed
1 task
@cdcabrera cdcabrera force-pushed the dev branch 2 times, most recently from 99cf0e8 to 184f298 Compare November 5, 2020 20:53
@cdcabrera cdcabrera changed the title WIP fix(inventoryList): apply consistent column widths feat(inventoryList,guestsList): issues/494 fixed column widths Nov 5, 2020
@cdcabrera cdcabrera marked this pull request as ready for review November 5, 2020 20:54
@codecov-io
Copy link

Codecov Report

Merging #472 into ci will decrease coverage by 0.03%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #472      +/-   ##
==========================================
- Coverage   93.08%   93.05%   -0.04%     
==========================================
  Files          70       70              
  Lines        2272     2290      +18     
  Branches      762      774      +12     
==========================================
+ Hits         2115     2131      +16     
- Misses        139      140       +1     
- Partials       18       19       +1
Impacted Files Coverage Δ
src/components/inventoryList/inventoryList.js 89.65% <0.00%> (-1.58%) ⬇️
src/components/loader/loader.js 100.00% <ø> (ø)
src/components/table/tableSkeleton.js 92.85% <83.33%> (-7.15%) ⬇️
...c/components/inventoryList/inventoryListHelpers.js 95.16% <91.66%> (+0.71%) ⬆️
src/components/guestsList/guestsList.js 98.43% <100.00%> (+0.02%) ⬆️
src/components/openshiftView/openshiftView.js 92.75% <100.00%> (ø)
src/components/rhelView/rhelView.js 89.13% <100.00%> (ø)
src/components/table/table.js 88.54% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c670525...184f298. Read the comment docs.

cdcabrera
cdcabrera commented Nov 5, 2020
View reviewed changes
Copy link
Member Author

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rework tableSkeleton tests

@cdcabrera
feat(inventoryList,guestsList): issues/494 fixed column widths
b67960a 
* inventoryList, guestsList, proptype expanded, loader colWidth
* inventoryListHelpers, apply filter column widths
* loader, pass colWidth
* openshiftView, rhelView, inventory fixed column widths
* table, check for valid cell contents, proptypes
* tableSkeleton, allow fixed column widths
* styling, fix guestsList padding
@cdcabrera cdcabrera merged commit a60a784 into RedHatInsights:ci Nov 6, 2020
@cdcabrera cdcabrera mentioned this pull request Nov 9, 2020
Merged
cdcabrera added a commit that referenced this pull request Nov 10, 2020
@cdcabrera
feat(inventoryList,guestsList): issues/494 fixed column widths (#472)
9aa6902 
* inventoryList, guestsList, proptype expanded, loader colWidth
* inventoryListHelpers, apply filter column widths
* loader, pass colWidth
* openshiftView, rhelView, inventory fixed column widths
* table, check for valid cell contents, proptypes
* tableSkeleton, allow fixed column widths
* styling, fix guestsList padding
@cdcabrera cdcabrera mentioned this pull request Nov 10, 2020
Merged
cdcabrera added a commit that referenced this pull request Dec 2, 2020
@cdcabrera
feat(inventoryList,guestsList): issues/494 fixed column widths (#472)
20c9034 
* inventoryList, guestsList, proptype expanded, loader colWidth
* inventoryListHelpers, apply filter column widths
* loader, pass colWidth
* openshiftView, rhelView, inventory fixed column widths
* table, check for valid cell contents, proptypes
* tableSkeleton, allow fixed column widths
* styling, fix guestsList padding
@cdcabrera cdcabrera mentioned this pull request Dec 2, 2020
Merged
cdcabrera added a commit that referenced this pull request Dec 2, 2020
@cdcabrera
feat(inventoryList,guestsList): issues/494 fixed column widths (#472)
4807a03 
* inventoryList, guestsList, proptype expanded, loader colWidth
* inventoryListHelpers, apply filter column widths
* loader, pass colWidth
* openshiftView, rhelView, inventory fixed column widths
* table, check for valid cell contents, proptypes
* tableSkeleton, allow fixed column widths
* styling, fix guestsList padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-io