Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bannerMessages): issues/541 state updates for filters #565

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(bannerMessages): issues/541 state updates for filters
    • appMessagesSelectors, adjust pass query, update components
    • productView, var/props name consistency

Notes

  • Flipping to the functional component for Satellite product views highlighted a long running issue created when fix(bannerMessages): issues/511 apply query filter
 #518 was implemented. The intention of fix(bannerMessages): issues/511 apply query filter
 #518 was to update the query based on the primary toolbar queries, which currently encompasses both Usage and SLA. The other products, RHEL and OpenShift, were able to "work around" this issue because of the component structure and prop drilling, exposing a functional Satellite component, and removing aspects of the prop drill causes the Satellite product view to not update the banner message like the other products... this PR corrects that issue.
  • @ntkathole

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with the appropriate account that has mismatched Cloud Meter data within the last 2 days based on the appropriate SLA or Usage filter selection
  5. navigate to Subs Watch Satellite product view
    • /subscriptions/satellite-sw/all
  6. confirm the banner displays upon selecting the related SLA or Usage filter

Example

...

Updates issue/story

Relates #518 #511 #502
#541

* appMessagesSelectors, adjust pass query, update components
* productView, var/props name consistency
@cdcabrera cdcabrera merged commit 31623e6 into RedHatInsights:ci Jan 27, 2021
cdcabrera added a commit that referenced this pull request Jan 27, 2021
* appMessagesSelectors, adjust query to update
* productView, var/props name consistency
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* appMessagesSelectors, adjust query to update
* productView, var/props name consistency
cdcabrera added a commit that referenced this pull request Feb 16, 2021
* appMessagesSelectors, adjust query to update
* productView, var/props name consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant