-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bannerMessages): issues/511 apply query filter #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
commented
Nov 30, 2020
* bannerMessages, query updates for banner display * openshiftView, rhelView, pass query to banner * appMessageSelectors, query pass-through
cdcabrera
force-pushed
the
issues/511-copy
branch
from
November 30, 2020 21:48
b3a917b
to
d9b83e1
Compare
Codecov Report
@@ Coverage Diff @@
## qa #518 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 74 74
Lines 2372 2374 +2
Branches 806 808 +2
=======================================
+ Hits 2216 2218 +2
Misses 138 138
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Nov 30, 2020
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
* bannerMessages, query updates for banner display * openshiftView, rhelView, pass query to banner * appMessageSelectors, query pass-through
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
* bannerMessages, query updates for banner display * openshiftView, rhelView, pass query to banner * appMessageSelectors, query pass-through
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
cdcabrera
added a commit
that referenced
this pull request
Dec 2, 2020
* bannerMessages, query updates for banner display * openshiftView, rhelView, pass query to banner * appMessageSelectors, query pass-through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Proxy run check
$ yarn
$ yarn start:proxy
Example
Copy update
Updates issue/story
#511 #502