Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bannerMessages): issues/511 apply query filter
 #518

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 30, 2020

What's included

  • fix(bannerMessages): issues/511 copy update
  • fix(bannerMessages): issues/511 apply query filter

    • bannerMessages, query updates for banner display
    • openshiftView, rhelView, pass query to banner
    • appMessageSelectors, query pass-through

Notes

  • Applies the query filter to the banner. This in turn adds an additional API call that fires on filter update.
    • The initial request was around the SLA filter... this should apply all graph related filters inclusive of UOM, and the exception of NO user applied granularity is set towards the banner message.
  • Minor copy adjustment per UX
  • @ntkathole

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with the appropriate account that has mismatched Cloud Meter data within the last 2 days based on the appropriate SLA or Usage filter selection
  5. with the banner message not initially displaying... confirm that when selecting the SLA or Usage filters the banner message now appears

Example

Copy update

Screen Shot 2020-11-30 at 3 50 22 PM

Updates issue/story

#511 #502

* bannerMessages, query updates for banner display
* openshiftView, rhelView, pass query to banner
* appMessageSelectors, query pass-through
@codecov-io
Copy link

Codecov Report

Merging #518 (d9b83e1) into qa (e1d818b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               qa     #518   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          74       74           
  Lines        2372     2374    +2     
  Branches      806      808    +2     
=======================================
+ Hits         2216     2218    +2     
  Misses        138      138           
  Partials       18       18           
Impacted Files Coverage Δ
src/components/openshiftView/openshiftView.js 93.93% <ø> (ø)
src/components/rhelView/rhelView.js 90.69% <ø> (ø)
src/components/bannerMessages/bannerMessages.js 97.43% <100.00%> (+0.06%) ⬆️
src/redux/selectors/appMessagesSelectors.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d818b...d9b83e1. Read the comment docs.

@cdcabrera cdcabrera merged commit ad20cf7 into RedHatInsights:qa Nov 30, 2020
cdcabrera added a commit that referenced this pull request Nov 30, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* bannerMessages, query updates for banner display
* openshiftView, rhelView, pass query to banner
* appMessageSelectors, query pass-through
cdcabrera added a commit that referenced this pull request Dec 2, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* bannerMessages, query updates for banner display
* openshiftView, rhelView, pass query to banner
* appMessageSelectors, query pass-through
cdcabrera added a commit that referenced this pull request Dec 2, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* bannerMessages, query updates for banner display
* openshiftView, rhelView, pass query to banner
* appMessageSelectors, query pass-through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants