Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select,toolbarFields): ent-3879 apply test attributes #687

Merged
merged 1 commit into from
May 24, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(select,toolbarFields): ent-3879 apply test attributes
    • select, allow data- attributes
    • toolbarFields, apply test attributes

Notes

  • @mirekdlugosz the data-test attributes we apply are added after-the-fact, we may need to take page load into consideration
    • the test attributes are as follows
      • display name search = data-test="toolbarFieldDisplayName"
      • granularity = data-test="toolbarFieldGranularity"
      • ranged monthly (OpenShift On-demand) = data-test="toolbarFieldRangeGranularity"
      • uom = data-test="toolbarFieldUom"

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login and inspect the various elements for the data-test attribute

Example

...

Updates issue/story

ent-3879

* select, allow data- attributes
* toolbarFields, apply test attributes
@cdcabrera cdcabrera added story New feature, or process work 202108 project phase labels May 24, 2021
@cdcabrera cdcabrera merged commit a823498 into RedHatInsights:ci May 24, 2021
cdcabrera added a commit that referenced this pull request Jun 10, 2021
* select, allow data- attributes
* toolbarFields, apply test attributes
cdcabrera added a commit that referenced this pull request Jul 13, 2021
* select, allow data- attributes
* toolbarFields, apply test attributes
cdcabrera added a commit that referenced this pull request Jul 13, 2021
* select, allow data- attributes
* toolbarFields, apply test attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202108 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant