Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rhosak): ent-4689 activate billing provider #894

Merged
merged 2 commits into from
May 23, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 22, 2022

What's included

  • feat(rhosak): ent-4689 activate billing provider
    • product config rhosak, add secondary toolbar field config
  • fix(toolbarFieldBillingProvider): ent-4689 tally query
    • rhsmConstants, allow tally-capacity access billing provider

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the RHOSAK product display applies the UX/design associated with ENT-4689

Example

UPDATED screenshots
Screen Shot 2022-05-23 at 12 23 09 PM
Screen Shot 2022-05-23 at 12 23 19 PM

OUTDATED screenshots

What it looks like when the configuration for RHOSAK is applied
Screen Shot 2022-02-08 at 12 45 10 AM

What inventory activation would resemble when the configuration for RHOSAK is applied
Screen Shot 2022-02-17 at 5 21 33 PM (2)

Updates issue/story

ent-4689
relates #883 #893

@cdcabrera cdcabrera added the 202204 project phase label Feb 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #894 (9ab11ec) into ci (c88769d) will decrease coverage by 0.24%.
The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #894      +/-   ##
==========================================
- Coverage   94.32%   94.08%   -0.25%     
==========================================
  Files         130      131       +1     
  Lines        3964     4021      +57     
  Branches     1550     1568      +18     
==========================================
+ Hits         3739     3783      +44     
- Misses        208      221      +13     
  Partials       17       17              
Impacted Files Coverage Δ
...c/components/toolbar/toolbarFieldSelectCategory.js 72.91% <0.00%> (-24.31%) ⬇️
src/redux/types/queryTypes.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/components/productView/productViewContext.js 97.29% <100.00%> (+0.03%) ⬆️
src/components/toolbar/toolbar.js 100.00% <100.00%> (ø)
src/components/toolbar/toolbarContext.js 100.00% <100.00%> (ø)
.../components/toolbar/toolbarFieldBillingProvider.js 100.00% <100.00%> (ø)
src/config/product.rhosak.js 86.04% <100.00%> (+0.33%) ⬆️
src/redux/reducers/viewReducer.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88769d...9ab11ec. Read the comment docs.

@cdcabrera
Copy link
Member Author

This PR being merged is dependent on #893 and related API updates around ENT-4689

@cdcabrera cdcabrera added the blocked Prevented from continuing label Mar 3, 2022
@cdcabrera cdcabrera force-pushed the ent-4689-activate-billprovider branch from c7924a9 to 7219596 Compare March 3, 2022 21:58
@cdcabrera cdcabrera added the 202208 project phase label Apr 12, 2022
@cdcabrera cdcabrera force-pushed the ent-4689-activate-billprovider branch from 7219596 to 9ab11ec Compare April 22, 2022 19:24
@cdcabrera cdcabrera force-pushed the ent-4689-activate-billprovider branch from 9ab11ec to 5781ad7 Compare May 23, 2022 16:21
@cdcabrera cdcabrera marked this pull request as ready for review May 23, 2022 16:28
@cdcabrera cdcabrera removed the blocked Prevented from continuing label May 23, 2022
@cdcabrera cdcabrera force-pushed the ent-4689-activate-billprovider branch from 5781ad7 to eddce5b Compare May 23, 2022 19:26
@cdcabrera cdcabrera merged commit 7d5a3ea into RedHatInsights:ci May 23, 2022
cdcabrera added a commit that referenced this pull request May 23, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request May 25, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request May 25, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request May 26, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* rhsmConstants, allow tally-capacity access billing provider
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* rhsmConstants, allow tally-capacity access billing provider
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* rhsmConstants, allow tally-capacity access billing provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase 202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants