-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for environments during registration #121
Conversation
jirihnidek
commented
Jun 21, 2024
- It is possible to specify environments during connecting (RHSM registration) using CLI option --environment
- It is possible to specify multiple environmets
- Added beforeCoonectAction checking combinations of CLI options
* It is possible to specify environments during connecting (RHSM registration) using CLI option --environment * It is possible to specify multiple environmets * Added beforeCoonectAction checking combinations of CLI options
To test this functionality it is necessary to create some testing environments. If you use local candlepin server, then you create new environments using following commands:
Then you can test connecting system using
As you can see, you can use CLI option There is no command that could be used for getting list of valid environments, because there is no D-Bus API for getting such list. User just has to know IDs of environments. It is also reason why |
/packit build |
Build started 10:40 ... It means that you have to wait 6 minutes in some queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, concise and easy to follow. Thanks for the environment steps. I tested this against a rhel-9 machine and selinux denied rhc from accessing subscription-manager?
Outside of that the environments successfully connect, and the activation-key errors in the beforeConnectAction work as expected.
LGTM after a rebase.
We agreed to delay merging of this PR until we confirm the requirements with depend teams. |
Closing this PR due to this: https://issues.redhat.com/browse/RHEL-53436 We can reopen later, when needed. |