fix: skip basic auth for rhc+satellite #138
Conversation
| @@ -25,6 +25,8 @@ def test_connect(external_candlepin, rhc, test_config, auth): | |||
| """Test if RHC can connect to CRC using basic auth and activation key, | |||
| Also verify that yggdrasil service is in active state afterward. | |||
| """ | |||
| if "satellite" in test_config.environment and auth == "basic": | |||
There was a problem hiding this comment.
please add a ref to bug/Jira crad for the issue as a comment here and in commit message
There was a problem hiding this comment.
please add some description of change and reference bug in commit message as well
zhangqianqian
force-pushed
the
rhc_satellite_support_activationkey
branch
from
ec524e8 to
375045b
Compare
zhangqianqian
force-pushed
the
rhc_satellite_support_activationkey
branch
from
861c949 to
e396228
Compare
There was a problem hiding this comment.
Thanks for the PR, Unfortunately, this PR does not satisfy general requirements on PRs and commits. Each commit has to include description of a change. The PR itself has to include description of provided changes. Lint errors are also not acceptable.
Please, don't do any changes in Go code.
I also don't understand why should we skip basic auth for satellite?
I'm considering closing this PR.
zhangqianqian
force-pushed
the
rhc_satellite_support_activationkey
branch
from
83c2e80 to
e396228
Compare
|
@zhangqianqian do you aware of this PR: #121 ? |
|
@jirihnidek just FYI- https://issues.redhat.com/browse/RHEL-53436 |
I mean, is this change really necessary, when PR #121 exists and it will be merged in the future? |
|
Thanks for your review and suggestion, @Archana-PandeyM . Hi, @jirihnidek , I did not change any Go code, and I don’t know why the lint errors happened in my PR. I will not do any changes in Go code. Of course I know #121 which is listed in bug https://issues.redhat.com/browse/RHEL-53436. As per Christian’s statement in bug https://issues.redhat.com/browse/RHEL-53436, supporting basic auth for satellite is not the goal of the first milestone on supporting Satellite. As the QE who executes the rhc testing with satellite, I would like to keep the test cases updated with the current testing goal(only activation key is supported for satellite for now). When we start the next milestone on supporting satellite when basic auth is supported, I will modify the test cases again. All my actions on the test code are just making sure the test cases reflects the testing goals. If #121 is merged now, we also have the reason to close this PR. If we can not make sure #121 can be merged before next test cycle, I prefer merge this PR first. |
No description provided.