fix #88 avoid loading null fields to Redis Hash (#90)

* fix #88 avoid loading null fields to Redis Hash * Update ReadSource.java
RedisGears · Aug 7, 2022 · 5377be3 · 5377be3
1 parent fcf849a
commit 5377be3
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/src/main/java/com/redislabs/ReadSource.java b/src/main/java/com/redislabs/ReadSource.java
@@ -82,9 +82,11 @@ public void foreach(KeysReaderRecord r) throws Exception {
           GearsBuilder.overrideReply(error);
           throw new Exception(error);
         }
-        command.add(propKey);
         Object value = e.getValue();
-        command.add(pd.convertToStr(value));
+        if (value != null) {
+          command.add(propKey);
+          command.add(pd.convertToStr(value));
+        }
       }
 
 
@@ -131,16 +133,22 @@ public void foreach(KeysReaderRecord r) throws Exception {
             GearsBuilder.overrideReply(error);
             throw new Exception(error);
           }
-          response.add(propKey);
           Object value = e.getValue();
-          response.add(pd.convertToStr(value));
+          if (value != null){
+            response.add(propKey);
+            response.add(pd.convertToStr(value));
+          }
         }
       }else {
         for(String f : fields) {
           if(res.containsKey(f)) {
             PropertyData pd = getPropertyMapping(f);
             Object value = res.get(f);
-            response.add(pd != null ? pd.convertToStr(value) : value.toString());
+            if( value == null) {
+              response.add(null);
+            } else {
+              response.add(pd != null ? pd.convertToStr(value) : value.toString());
+            }
           }else {
             response.add(null);
           }