Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read through fails to read rows with NULL values #88

Closed
shkediy opened this issue Aug 5, 2022 · 0 comments · Fixed by #90
Closed

Read through fails to read rows with NULL values #88

shkediy opened this issue Aug 5, 2022 · 0 comments · Fixed by #90

Comments

@shkediy
Copy link
Contributor

shkediy commented Aug 5, 2022

If a row in the database contains a null value for some column that does not have not-null property set to true (meaning that it can have a null value), read through fails to read that row.
to reproduce, insert a row that have a null value for some property, then try "hgetall ".
The command returns:
(empty array)

The RG.GETEXUCUTION output show:

    1. "shard_id"
    2. "0000000000000000000000000000000000000144"
    3. "execution_plan"
      1. "status"
      2. "done"
      3. "shards_received"
      4. (integer) 0
      5. "shards_completed"
      6. (integer) 0
      7. "results"
      8. (integer) 0
      9. "errors"
      1. "java.lang.NullPointerException|\tat com.redislabs.PropertyData.convertToStr(PropertyData.java:64)|\tat com.redislabs.ReadSource.foreach(ReadSource.java:87)|\tat com.redislabs.ReadSource.foreach(ReadSource.java:18)|"
    4. "total_duration"
    5. (integer) 1221
    6. "read_duration"
    7. (integer) 0
    8. "steps"
        1. "type"
        2. "foreach"
        3. "duration"
        4. (integer) 0
        5. "name"
        6. "JVM_Foreach"
        7. "arg"
        8. "java object"
        1. "type"
        2. "map"
        3. "duration"
        4. (integer) 0
        5. "name"
        6. "JVM_ToJavaRecordMapper"
        7. "arg"
        8. ""

It looks like it throws an exception when trying to convert the null value to string. It should ignore a null value.

@gkorland gkorland linked a pull request Aug 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant