Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diggy-map patch #1032

Merged
merged 8 commits into from
Feb 15, 2020
Merged

Diggy-map patch #1032

merged 8 commits into from
Feb 15, 2020

Conversation

Claude477
Copy link
Contributor

Diggy-map patch by BlueRock

@BlueRock2
Copy link
Contributor

BlueRock2 commented Feb 5, 2020

Description: In Factorio 0.18 particles are now handled using LuaSurface::create_particle() instead of create_entity. This PR is to make the needed changes to update Diggy. Was seeing various issues with current Diggy code in 0.18. Not only were particles not displaying, but it was also causing unexpected issues such as inconsistent ceiling collapses, biters not spawning from individual rocks (only from caves) and bot mining not working.

@BlueRock2 BlueRock2 mentioned this pull request Feb 6, 2020
@Claude477
Copy link
Contributor Author

yup this is working need w8 for merge it in server

Copy link
Member

@SimonFlapse SimonFlapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I understand it has been tested.

@Claude477
Copy link
Contributor Author

Yup this even running in S6-server allready to go.

Merging this hail hydra particle fix (PR 1035) with PR 1032 (diggy patch for 0.18) since all of the updates are related to the particle changes in Factorio 0.18
@BlueRock2
Copy link
Contributor

Merged hail hydra particle fix (PR 1035) with this PR since all of the updates are related to the particle changes in Factorio 0.18. Tested hail hydra update yesterday by setting debug and cheat mode to true, set evolution to 100%, and ran /c game.player.force.research_all_technologies() for weapon damage upgrades. Verified blood explosions occurred on alien death (which is a larger effect than normal alien damage particles). Also verified additional aliens randomly spawn on death as expected with hail hydra.

@Claude477
Copy link
Contributor Author

all checked out ready to merge =)

@grilledham grilledham merged commit 84ccb2a into Refactorio:develop Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants