-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diggy-map patch #1032
Diggy-map patch #1032
Conversation
This update your fork
Description: In Factorio 0.18 particles are now handled using LuaSurface::create_particle() instead of create_entity. This PR is to make the needed changes to update Diggy. Was seeing various issues with current Diggy code in 0.18. Not only were particles not displaying, but it was also causing unexpected issues such as inconsistent ceiling collapses, biters not spawning from individual rocks (only from caves) and bot mining not working. |
yup this is working need w8 for merge it in server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I understand it has been tested.
Yup this even running in S6-server allready to go. |
Merging this hail hydra particle fix (PR 1035) with PR 1032 (diggy patch for 0.18) since all of the updates are related to the particle changes in Factorio 0.18
Merged hail hydra particle fix (PR 1035) with this PR since all of the updates are related to the particle changes in Factorio 0.18. Tested hail hydra update yesterday by setting debug and cheat mode to true, set evolution to 100%, and ran /c game.player.force.research_all_technologies() for weapon damage upgrades. Verified blood explosions occurred on alien death (which is a larger effect than normal alien damage particles). Also verified additional aliens randomly spawn on death as expected with hail hydra. |
all checked out ready to merge =) |
Diggy-map patch by BlueRock