[TaskCanceledExceptionDestructurer] Destrucutured object type inconsi…

…stent #493
RehanSaeed · May 18, 2022 · bf2df9d · bf2df9d
1 parent b2d6f08
commit bf2df9d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Source/Serilog.Exceptions/Destructurers/TaskCanceledExceptionDestructurer.cs b/Source/Serilog.Exceptions/Destructurers/TaskCanceledExceptionDestructurer.cs
@@ -40,13 +40,13 @@ public override void Destructure(
     /// <param name="task">The task.</param>
     /// <param name="innerDestructure">The inner destructure.</param>
     /// <returns>The destructured task.</returns>
-    internal static object DestructureTask(
+    internal static object? DestructureTask(
         Task? task,
         Func<Exception, IReadOnlyDictionary<string, object?>?> innerDestructure)
     {
         if (task is null)
         {
-            return "null";
+            return null;
         }
 
         var taskStatus = task.Status.ToString("G");

diff --git a/Tests/Serilog.Exceptions.Test/Destructurers/TaskCanceledExceptionDestructurerTest.cs b/Tests/Serilog.Exceptions.Test/Destructurers/TaskCanceledExceptionDestructurerTest.cs
@@ -61,7 +61,7 @@ public void TaskCanceledException_TaskNull()
         // Assert
         var tce = ex.Should().BeOfType<TaskCanceledException>().Which;
         var exceptionDetails = ExtractExceptionDetails(LogAndDestructureException(tce));
-        Assert_ContainsPropertyWithValue(exceptionDetails, nameof(TaskCanceledException.Task), "null");
+        Assert_ContainsPropertyWithValue(exceptionDetails, nameof(TaskCanceledException.Task), null);
     }
 
     [Fact]