Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TaskCanceledExceptionDestructurer] Destructured object type inconsistent #493

Closed
Guymestef opened this issue Mar 18, 2022 · 1 comment
Closed
Labels
bug Issues describing a bug or pull requests fixing a bug.

Comments

@Guymestef
Copy link

Describe the bug

When Task property is null, the string "null" is added to the property bag.
When Task is not null, an object is added to the property bag.

The inconsistent type for the property added to the bag is generating a conflict mapping issue when using elasticsearch sink to store logs, preventing the log to be successfully pushed to elasticsearch.

Steps to reproduce

When using elasticsearch sink, log a TaskCanceledException exception with null as Task
Then log a TaskCanceledException exception with a non null Task.

Expected behaviour

Consistent property bag type to be able to log TaskCanceledException

@Guymestef Guymestef added the bug Issues describing a bug or pull requests fixing a bug. label Mar 18, 2022
Guymestef pushed a commit to Guymestef/Serilog.Exceptions that referenced this issue Mar 18, 2022
@Guymestef Guymestef changed the title [TaskCanceledExceptionDestructurer] Destrucutured object type inconsistent [TaskCanceledExceptionDestructurer] Destructured object type inconsistent Mar 19, 2022
@RehanSaeed
Copy link
Owner

Fixed in #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug or pull requests fixing a bug.
Projects
None yet
Development

No branches or pull requests

2 participants