Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespaces are not traversed #88

Closed
dummdidumm opened this issue Aug 22, 2024 · 0 comments · Fixed by #89
Closed

namespaces are not traversed #88

dummdidumm opened this issue Aug 22, 2024 · 0 comments · Fixed by #89
Labels
bug Something isn't working

Comments

@dummdidumm
Copy link
Collaborator

When you have a namespace with declarations inside which reference imports, those imports are not marked as used and subsequently removed. Looking at the code there just seems no logic whatsoever to traverse namespaces in that regard.
@dummdidumm dummdidumm added the bug Something isn't working label Aug 22, 2024
dummdidumm added a commit that referenced this issue Aug 22, 2024
@dummdidumm
fix: better detection of references, handle namespace dependencies
Loading
Loading status checks…
f06429a 
fixes #86
fixes #88
@dummdidumm dummdidumm mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: better detection of references, handle namespace dependencies Rich-Harris/dts-buddy
1 participant
@dummdidumm