fix: better detection of references, handle namespace dependencies #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we don't traverse into those)
Merged
5 tasks
dummdidumm
commented
Aug 23, 2024
| if (!ts.isIdentifier(node)) return false; | ||
|
|
||
| if (node.parent) { | ||
| if (is_declaration(node.parent)) { | ||
| if (ts.isVariableStatement(node.parent)) { | ||
| return node === node.parent.declarationList.declarations[0].name; | ||
| return false; |
There was a problem hiding this comment.
I changed this because the previous statement didn't make sense - the node could never be equal to the right hand side, because the node itself can only ever be VariableDeclarationList
|
(side note: I recommend changing the default from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_1instead oferror#86: tweak the "is this a reference logic" to not care about method signatures, and not care about the sub parts of qualified names (i.e. we only care about X in aX.Y.Ztype reference, because we don't traverse into namespaces, and this can only be a namespace reference)import * as Xnamespace imports, they were not handled correctly before (a bit unrelated to this PR, but I came across it while investigating the whole namespace thing)