Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gripper_controllers for osx_arm64 #21

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

WiktorJ
Copy link
Contributor

@WiktorJ WiktorJ commented Feb 5, 2025

I'm unsure why the package was excluded from osx, but I ran pixi run build and all seems to work.
In ros-humble there is a comment that it doesn't work for Mac and Windows (https://github.com/RoboStack/ros-humble/blob/e9557aa1a82f7434f6203c2f8d18aafb43a42884/vinca_osx_arm64.yaml#L39) but it seems this is no longer the case.

I cannot test with intel hardware so adding just for Apple silicon.

@traversaro
Copy link
Member

traversaro commented Feb 5, 2025

I'm unsure why the package was excluded from osx, but I ran pixi run build and all seems to work. In ros-humble there is a comment that it doesn't work for Mac and Windows (https://github.com/RoboStack/ros-humble/blob/e9557aa1a82f7434f6203c2f8d18aafb43a42884/vinca_osx_arm64.yaml#L39) but it seems this is no longer the case.

Just FYI, the issue upstream was that back in time the plugin was not compiling on osx and so there was some cmake logic to skip actual compilation on osx, but that was probably fixed long ago but the cmake logic remaining, and it was removed in ros-controls/ros2_controllers#1471 .

@traversaro
Copy link
Member

I cannot test with intel hardware so adding just for Apple silicon.

I think we can add it on all platforms, if there are problems we can always fix them later.

@traversaro
Copy link
Member

I added gripper_controllers on osx-64, and bumped moveit_servo and ros2_controllers build number, so they rebuild without the dependency on gripper_controllers removed.

@traversaro
Copy link
Member

@WiktorJ feel free to check my additional changes and let me know if they make sense to you.

@Tobias-Fischer Tobias-Fischer merged commit 6e7079b into RoboStack:main Feb 5, 2025
5 checks passed
@WiktorJ
Copy link
Contributor Author

WiktorJ commented Feb 6, 2025

@traversaro Looks great! Thank you for taking care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants