Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: Should migrate data to RobotLocomotion/models per doc advice #11913

Closed
7 of 8 tasks
EricCousineau-TRI opened this issue Aug 8, 2019 · 6 comments
Closed
7 of 8 tasks
Assignees
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low type: cleanup

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Aug 8, 2019

Follow-up to #10811.

To relocate:

  • examples/atlas/urdf/meshes
  • examples/pr2/models/pr2_description/meshes
  • manipulation/models/allegro_hand_description/meshes
  • manipulation/models/iiwa_description/iiwa7
  • manipulation/models/iiwa_description/meshes

To deprecate and remove:

@EricCousineau-TRI EricCousineau-TRI self-assigned this Aug 8, 2019
@EricCousineau-TRI EricCousineau-TRI changed the title models: Should migrate data to RobotLocomotion/models per README advice models: Should migrate data to RobotLocomotion/models per doc advice Aug 8, 2019
@EricCousineau-TRI
Copy link
Contributor Author

FYI @IanTheEngineer

@jwnimmer-tri jwnimmer-tri added the component: build system Bazel, CMake, dependencies, memory checkers, linters label May 4, 2020
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented May 4, 2020

This is confusing a few new people every month, so I'm going to work on it.

@jwnimmer-tri jwnimmer-tri added the good first issue Thinking of contributing? These issues might be a good place to start. label May 15, 2020
@jwnimmer-tri
Copy link
Collaborator

\CC @IanTheEngineer

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Aug 2, 2021

It's possible that the resolution of #13942 will end up being a prerequisite for this work. If we decide that the sdformat / urdf files should move as well, it probably makes sense to do them as part of the same file relocation as the meshes.

The package URIs per #10531 might also come into play.

@jwnimmer-tri
Copy link
Collaborator

The only remaining one to port is the PR2. It's complicated by the fact that we're currently reprocessing those models with stl2obj and then installing the reprocessed copies. The easy fix is to commit the reprocessed files into the models repository. It might be worth seeing if there is any a more elegant solution available instead.

@jwnimmer-tri
Copy link
Collaborator

I'll roll the one remaining task into #13942, so we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low type: cleanup
Projects
None yet
Development

No branches or pull requests

2 participants