Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Remove pr2_description #21185

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Mar 24, 2024

These files will soon become part of package://drake_models, but since nothing inside Drake uses them in the meantime, we can remove them without waiting for the models bump.

The twin PR RobotLocomotion/models#41 is sufficient on its own for tracking progress towards their new home.

Towards #13942 (and #11913).


This change is Reviewable

These files will soon become part of drake_models, but since nothing
inside Drake uses them in the meantime, we can remove them without
waiting for the models bump.
@jwnimmer-tri jwnimmer-tri added release notes: fix This pull request contains fixes (no new features) priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html and removed status: do not merge status: do not review labels Mar 24, 2024
@jwnimmer-tri jwnimmer-tri changed the title [models] Move pr2_description into drake_models [examples] Remove pr2_description Mar 24, 2024
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review March 24, 2024 19:12
@jwnimmer-tri
Copy link
Collaborator Author

+@SeanCurtis-TRI for both reviews, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 52 of 52 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit 1d54460 into RobotLocomotion:master Mar 25, 2024
9 of 10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the pr2-description branch March 25, 2024 16:01
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
These files will soon become part of drake_models, but since nothing
inside Drake uses them in the meantime, we can remove them without
waiting for the models bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants