[workspace] Upgrade drake_models to latest commit #22321
Conversation
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @amcastro-tri)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
repository = "RobotLocomotion/models", commit = "80a5d2609daaeb6f86a63545e6933e0edda06cda", sha256 = "40b7ce8894c75ab8ec047d897fe1b423c1f119d3af8b293fda2232ff72ac4a7a", # noqa
Working temporary 40b7ce8 until the models PR #72 is merged.
There was a problem hiding this comment.
+@SeanCurtis-TRI for review please (both reviews?)
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers, missing label for release notes
jwnimmer-tri
changed the title
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @amcastro-tri)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, amcastro-tri (Alejandro Castro) wrote…
Working temporary 40b7ce8 until the models PR #72 is merged.
BTW 78cad6a331aa0610e8f84e463d28103d096bdb83 is the new sha you want here now.
|
BTW I corrected the PR title. Please use that subject when merging, not the commit message subject. |
SeanCurtis-TRI
added
release notes: fix
There was a problem hiding this comment.
+(release notes: fix)
+(status: single reviewer ok)
Need to update the sha.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
BTW
78cad6a331aa0610e8f84e463d28103d096bdb83is the new sha you want here now.
What he said.
amcastro-tri
force-pushed
the
bumps_drake_models
branch
from
94b4e9a to
6632c7a
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
What he said.
I believe done?
I think you guys mean the commit? I used the commit from the merge and asked bazel for the new checksum
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, amcastro-tri (Alejandro Castro) wrote…
I believe done?
I think you guys mean the commit? I used the commit from the merge and asked bazel for the new checksum
Yep. THe commit is also a sha. Just to keep things fun. :)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
Yep. THe commit is also a sha. Just to keep things fun. :)
Yup, sorry. I should have said "git commit sha".
There was a problem hiding this comment.
Dismissed @amcastro-tri from a discussion.
Reviewable status:complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
Working temporary 40b7ce8 until the models PR #72 is merged.
This change is