Fixes table top model #72
Conversation
…tia properties to this model
There was a problem hiding this comment.
+@jwnimmer-tri for review please. Thanks!
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
I can stay on as platform review.
+@DamrongGuoy for feature review, please.
Is it worth having it in this repository?
Yes. It's a tutorials model. The fact that it does not have a PBR texture is a defect that will eventually be fixed by adding texture image(s) into this repo.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee damrongguoy, platform LGTM missing (waiting on @amcastro-tri and @DamrongGuoy)
a discussion (no related file):
Note that per https://drake.mit.edu/model_version_control.html you must open a Drake PR that bumps to this models sha and it must pass Drake CI prior to us merging this PR. Otherwise, we won't have any automated testing for typos, etc.
There was a problem hiding this comment.
got it. Done.
Drake PR in flight 22321
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee damrongguoy, platform LGTM missing (waiting on @DamrongGuoy and @jwnimmer-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @amcastro-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [jwnimmer-tri] (waiting on @amcastro-tri)
|
BTW, I did SolidBoxWithMass() to confirm the numbers. They are good! |
Models with no inertia properties are dangerous. We add non-zero inertia properties to this model.
Note: consider removing this model? its just a simple box. Is it worth having it in this repository?
This change is