[pr2_description] Move Drake files into here #41
Conversation
There was a problem hiding this comment.
+@RussTedrake for both reviews, please.
This is towards RobotLocomotion/drake#13942 where we want to move all of our model files from Drake into this models menagerie (and convert them to glTF, etc).
Reviewable status: all discussions resolved, LGTM missing from assignee russtedrake, platform LGTM missing (waiting on @RussTedrake)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee russtedrake, platform LGTM missing (waiting on @RussTedrake)
pr2_description/LICENSE line 1 at r1 (raw file):
WIP We're not sure yet. Need to fix before merging this PR.
@RussTedrake you added the PR2 to Drake in RobotLocomotion/drake@ab6eb22. Where did the URDF and STL file come from originally, and what license are they under?
There was a problem hiding this comment.
sorry for missing this til now.
Reviewable status: 1 unresolved discussion, platform LGTM from [russtedrake] (waiting on @jwnimmer-tri and @RussTedrake)
pr2_description/LICENSE line 1 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
@RussTedrake you added the PR2 to Drake in RobotLocomotion/drake@ab6eb22. Where did the URDF and STL file come from originally, and what license are they under?
:gulp: sorry. I'm pretty sure I would have gotten them from ROS. https://github.com/PR2/pr2_common/ . (If needed, one could potentially pull them over from there now, and clean things up; we would likely make a few different choices now). Unfortunately, I don't see clear licensing in that quite mainstream repo.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [russtedrake] (waiting on @jwnimmer-tri and @RussTedrake)
pr2_description/LICENSE line 1 at r1 (raw file):
Previously, RussTedrake (Russ Tedrake) wrote…
:gulp: sorry. I'm pretty sure I would have gotten them from ROS. https://github.com/PR2/pr2_common/ . (If needed, one could potentially pull them over from there now, and clean things up; we would likely make a few different choices now). Unfortunately, I don't see clear licensing in that quite mainstream repo.
Working
There is BSD listed in the repo. I'll update to match that here.
This were copied from Drake as of 665721e9, notably copying the stl2obj output obj files, not the original stl files. The only changes to the URDF are to the URL paths.
jwnimmer-tri
force-pushed
the
pr2-description
branch
from
42b5fe6 to
fdfebd1
Compare
This were copied from Drake as of 665721e9, notably copying the stl2obj output obj files, not the original stl files.
The only changes to the URDF are to the URL paths.
Twin PR: RobotLocomotion/drake#21185
This change is