interactivemarkers: get the correct transformation for sub-markers #72
Conversation
tested with http://www.cse.wustl.edu/~dvl1/stuff/marker_marker_marker_frame_bug.zip - submarker now shows up where you'd expect it to also made sure examples/interactivemarkers.html still works
|
This version doesn't seem to work on a more complex example. I'm working on narrowing in to find the exact cause now. |
|
In the above example, rviz shows the marker at 1m when the IM header is /up or /world. Using the standard version of ros3djs, it appears at 0m and 1m for /world and /up respectively. With this version of ros3djs, it appears at 1m and 2m for /world and /up respectively. |
…o its sub-Markers
|
updated the pull request - together with RobotWebTools/tf2_web_republisher#14, I believe it works correctly now. |
|
Works for me in both the toy example and my more complex example. Thanks for the fix! |
|
Any reason not to merge this? |
|
I haven't had time to test this yet, if you can confirm https://github.com/RobotWebTools/ros3djs/blob/develop/examples/interactivemarkers.html works as expected I can go ahead and merge! |
interactivemarkers: get the correct transformation for sub-markers
tested with http://www.cse.wustl.edu/~dvl1/stuff/marker_marker_marker_frame_bug.zip - submarker now shows up where you'd expect it to
also made sure examples/interactivemarkers.html still works
RE: #71 - ros3djs now mirrors RViz, but it's unclear if thats ultimately the desired behavior