Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: My Account using React #18106

Merged
merged 10 commits into from
Jul 17, 2020
Merged

Rewrite: My Account using React #18106

merged 10 commits into from
Jul 17, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 1, 2020 •
edited
Loading

Proposed changes

Rewrite all Profile pages using react

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.5.0 milestone Jul 1, 2020
@ggazzo ggazzo requested a review from a team July 1, 2020 14:13
@ggazzo ggazzo changed the title Rewrite My account profile pages [WIP] Rewrite My account profile pages Jul 1, 2020
gabriellsh and others added 6 commits July 1, 2020 16:41
@gabriellsh
Merge branch 'develop' into rewrite/accounts
35b42be
@gabriellsh
Merge branch 'develop' into rewrite/accounts
b7668c5
@gabriellsh @tassoevan @ggazzo
Account Profile rewritten (#18076)
96b094a 
Co-authored-by: Tasso Evangelista <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into rewr…
2205323 
…ite/accounts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
@gabriellsh
[NEW] Account Preferences rewritten (#18151)
a5c24c0 
* Rewrite user Preferences

* Delete old files

* Fix page Label

* Review

* Fix style
@gabriellsh @tassoevan
[NEW] Account Security & Encryption rewritten (#18192)
dcf603d 
* Change NotAuthorizedPage locations

* 2fa done

* Finished e2e

* Delete old Files

* autoFocus and Enter key behaviour

* Fix page name

* Update fuselage

* Review

* Update i18n string

* Break i18n string in BackupCodesModal

* Update packages/rocketchat-i18n/i18n/de.i18n.json

* Update packages/rocketchat-i18n/i18n/sl-SI.i18n.json

Co-authored-by: Tasso Evangelista <[email protected]>
@tassoevan tassoevan marked this pull request as draft July 17, 2020 03:57
@tassoevan tassoevan changed the title [WIP] Rewrite My account profile pages [NEW] "My Account" rewritten Jul 17, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@gabriellsh @tassoevan
[NEW] Personal Access Tokens rewritten (#18206)
19001a4 
* Finished refactor accountTokens

* Use useSetModal hook

* Prefer children over renderRow on GenericTable

* Fix AddToken markup

* Move InfoModal to its own module

* Move hook calls into inner components

* Block access to AccountTokensPage rendering

Co-authored-by: Tasso Evangelista <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request fixes 2 alerts when merging 19001a4 into 12f5ce7 - view on LGTM.com

fixed alerts:

  • 1 for Duplicate HTML element attributes
  • 1 for Useless assignment to property

@RocketChat RocketChat deleted a comment from lgtm-com bot Jul 17, 2020
@ggazzo ggazzo marked this pull request as ready for review July 17, 2020 14:20
@ggazzo ggazzo merged commit 1bed297 into develop Jul 17, 2020
@ggazzo ggazzo changed the title [NEW] "My Account" rewritten Rewrite: My Account using React Jul 17, 2020
@tassoevan tassoevan deleted the rewrite/accounts branch July 17, 2020 21:12
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tassoevan tassoevan

@ggazzo ggazzo

@MartinSchoeler MartinSchoeler

@gabriellsh gabriellsh

Labels
type: improvement ui/ux
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @tassoevan @MartinSchoeler @gabriellsh