Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][ENTERPRISE] Make AutoSelect algo take current agent load in consideration #22611

Merged
merged 12 commits into from
Jul 20, 2021

Conversation

KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2021

This pull request introduces 1 alert when merging ebf0619 into 6dd2e35 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 1 alert when merging eb9a6b8 into 350fa30 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

murtaza98
murtaza98 previously approved these changes Jul 13, 2021
app/models/server/models/LivechatDepartmentAgents.js Outdated Show resolved Hide resolved
app/models/server/models/Users.js Outdated Show resolved Hide resolved
app/models/server/models/Users.js Outdated Show resolved Hide resolved
app/models/server/models/Users.js Show resolved Hide resolved
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Update, added these 2 comments after approving the PR 🙈 Please resolve it b4 merging. Thanks 😄
#22611 (comment)
#22611 (comment)

@KevLehman KevLehman merged commit 81f5b52 into develop Jul 20, 2021
@KevLehman KevLehman deleted the fix/omnichannel-auto-select-queue branch July 20, 2021 23:02
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants