-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.17.0 #22825
Merged
Merged
Release 3.17.0 #22825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#22452) * fix error message when creating an user with blocked username * update tests * fix i18n * fix eslint error Co-authored-by: dougfabris <[email protected]>
* improve: change OTR icon * chore: update latest @rocket.chat/icons Co-authored-by: dougfabris <[email protected]>
Merge master into develop & Set version to 3.17.0-develop
* [IMPROVE] Paginated multiselect for EE tags * add missing tag interface * rename ILivechatTag interface * Add type to endpoint Co-authored-by: Rafael Ferreira <[email protected]>
…-agent and chats-per-department (#22406)
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
* onlyMyDepartments in hook * sort items in useDepartmentList * fix flex shrink
* Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * Fix vars Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]>
…lback (#22413) * Fix Visitor Inactivity monitor not working * Add comment * Fix tslint issue Co-authored-by: Renato Becker <[email protected]>
* create roles.delete endpoint * add tests for new endpoint Co-authored-by: pierre-lehnen-rc <[email protected]>
…22781) * contextual-bar monitor permissions * Add monitor to livechat-canned-responses permission * omnichannel canned-responses monitor permissions * remove button * fix Co-authored-by: Kevin Aleman <[email protected]>
* contextual-bar monitor permissions * Add monitor to livechat-canned-responses permission * omnichannel canned-responses monitor permissions * remove button * fix * fix filters for monitors Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
* Fix quote message not working for livechat visitors (cherry picked from commit 4fa4f66) * Apply suggestions from code review Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Kevin Aleman <[email protected]>
* fix text wrap + preview * remove console.log * fix Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: ggazzo <[email protected]> Co-authored-by: Noach Magedman <[email protected]>
…22794) Co-authored-by: Tasso Evangelista <[email protected]>
sampaiodiego
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-07-30 · 7 🎉 · 19 🚀 · 39 🐛 · 56 🔍 · 28 👩💻👨💻
Engine versions
12.22.1
6.14.1
3.4, 3.6, 4.0, 4.2
1.27.1
🎉 New features
roles.delete
endpoint (#22497 by @lucassartor)Collect data about LDAP, SAML, CAS and OAuth usage. (#22719)
Convert Team to Channel (#22476)
Federation setup (#22208)
Logout other user endpoint (#22661)
Monitoring Track messages' round trip time (#22676)
Track messages' roundtrip time from backend saves time to the time when received back from the oplog allowing track of oplog slowness.
Prometheus metric:
rocketchat_messages_roundtrip_time
REST endpoint to remove User from Role (#20485 by @Cosnavel & @lucassartor)
🚀 Improvements
Canned responses (#22703 by @rafaelblink)
Change message deletion confirmation modal to toast (#22544)
Changed a timed modal for a toast message
![image](https://user-images.githubusercontent.com/40830821/124192670-0646f900-da9c-11eb-941c-9ae35421f6ef.png)
Configuration for indices in Apps-Engine models (#22705)
Add
appId
field to the data saved by the SchedulerAdd
appId
index torocketchat_apps_persistence
modelSkip "trash collection" when deleting records from
rocketchat_apps_persistence
Add a new setting to control for how long we should keep logs from the apps
Make
shortcut
field of canned responses unique (#22700)Paginated department select on forward chat (#22123)
Changes the department dropdown to use the new paginated selects, allowing for searching and displaying more than 50 departments
Paginated multiselect for EE tags (#22315 by @rafaelblink)
This uses the paginated multiselect for the EE tags selection, allowing more than 50 tags to be shown.
Preview message URLs only once (#22516 by @nmagedman)
Refactor
livechat.registerGuest
function (#22684)Replace OTR Icon on Contextual Bar & Update Icons (#22377)
Replace remaing discussion creation modals with React modal. (#22448)
before
after
Return open room if available for visitors (#22742)
Rewrite Enter Encryption Password Modal (#22456)
before
after
Aditional Improves:
Rewrite OTR modals (#22583)
Rewrite Save Encryption Password Modal (#22447)
before
after
Rewrite sidebar footer as React Component (#22687)
Rewrite URL check modal (#22540)
Sidebar icons margins (#22498)
Update README.md (#22462)
Wrong error message when trying to create a blocked username (#22452 by @lucassartor)
When trying to create a user with a blocked username, the UI was showing generic error message that it wasn't very detailed.
Old error message:
![image](https://user-images.githubusercontent.com/49413772/123120080-6d203e80-d41a-11eb-8c87-64e34334c856.png)
New error message:
![aaa](https://user-images.githubusercontent.com/49413772/123120251-8c1ed080-d41a-11eb-8dc2-d7484923d851.PNG)
🐛 Bug fixes
ENTERPRISE: Engagement Dashboard displaying incorrect data about active users (#22381)
ENTERPRISE: Make AutoSelect algo take current agent load in consideration (#22611)
ENTERPRISE: Race condition on Omnichannel visitor abandoned callback (#22413)
As you can see here the
predictedVisitorAbandonment
flag is not set if the room object doesn't havev.lastMessageTs
property. So we need to always make sure thev.lastMessageTs
is set before this method is called.Currently the
v.lastMessageTs
is being set in this (lets call this hook-1) hook which hasHIGH
priorityand the
predictedVisitorAbandonment
check is inturn performed in this (let call this hook-2) hook which is alsoHIGH
priority.So ideally we'd except the hook-1 to be called b4 hook-2, however currently since both of them are at same priority, there is no way to control which one is executed first. Hence in this PR, I'm making the priority of hook-2 as
MEDIUM
to keeping the priority of hook-1 the same as b4, i.e.HIGH
. This should make sure that the hook-1 is always executed b4 hook-2Admin page crashing when commit hash is null (#22057 by @cprice-kgi)
If the commit hash happens to be null, the administration page will still attempt to slice the value and display it. This causes the admin page to not display, and essentially crash the web app. This fixes it by checking for a null value first.
Blank screen in message auditing DM tab (#22763)
The DM tab in message auditing was displaying a blank screen, instead of the actual tab.
Bugs in AutoCompleteDepartment (#22414)
Call button is still displayed when the user doesn't have permission to use it (#22170)
Hide 'Call' buttons from the tab bar for muted users;
Display an error when a muted user attempts to enter a call using the 'Click to Join!' button.
Can't see full user profile on team's room (#22355)
before
after
aditional fix 🚀
TeamsMembers
component removedCannot create a discussion from top left sidebar as a user (#22618 by @lucassartor)
When trying to create a discussion using the top left sidebar modal with an role that don't have the
view-other-user-channels
permission, an empty list would be shown, which is a wrong behavior.Also, when being able to use this modal, discussions were listed as options, which is also a wrong behavior as there can't be nested discussions.
This PR looks to fix both these issues.
Old behavior:
![old](https://user-images.githubusercontent.com/49413772/124960017-3c333280-dff2-11eb-86cd-b2638311517e.png)
New behavior:
![image](https://user-images.githubusercontent.com/49413772/124958882-05a8e800-dff1-11eb-8203-b34a4f1c98a0.png)
Channel is automatically getting added to the first option in move to team feature (#22670)
Channels or Teams deleted are not removed from the sidebar. (#22613)
Checks the list of agents if at least one is online (#22584)
Confirm owner change process when deleting own account (#22609)
Content-Security-Policy ignoring CDN configuration (#22791 by @nmagedman)
Create discussion modal - cancel button and invite users alignment (#22718)
Changes in "open discussion" modal
crush in the getChannelHistory method (#22667 by @MaestroArt)
Deleting own account asks for the username in the UI instead of the password (#22405)
Emoji not rendered on attachments description (#22437)
Error in permission check for getLivechatDepartmentByNameOrId method in Apps (#22545)
Update the Apps-Engine with a fix for the permission check on the
getLivechatDepartmentByNameOrId
methodLivechat apps permission error (#22511)
Updated Apps-Engine version fixes errors with apps using livechat features.
Livechat config endpoint is not returning all settings (#22686)
Livechat webhook request without headers (#22589)
Markdown for UiKit blocks (#22619)
Omnichannel - Fix issue with modals on room preview mode. (#22541)
Omnichannel/Twilio - When a file is sent as first message, chat is not queued (#22590)
Prune messages not applying the user filter (#22506)
Put title into AutocompleteDepartment components (#22417)
Dependencies: fix: endReached prop in _Options of PaginatedSelectFiltered Component fuselage#475
Quote message not working for Livechat visitors (#22586)
Before:
After:
Redirect to login after delete own account (#22499)
Redirect the user to login after delete own account
Aditional fixes:
before
after
Remove stack traces from Meteor errors when debug setting is disabled (#22699)
Fix 'not iterable' errors in the
normalizeMessage
function;Remove stack traces from errors thrown by the
jitsi:updateTimeout
(and otherMeteor.Error
s) method.Rewrite CurrentChats to TS (#22424)
Sort AutocompleteDepartmentsMultiple (#22419)
status message won't show up for other users (#22110)
replace the current blaze block that queries the local session store by a react component that fetches memoized user data
Store department value correctly (#22685)
Support ID param on createVisitor method (#22772)
UIKit URL prop being ignored for buttons (#22579)
Unnecessary space on members list footer (#22514)
Use room's last message time when visitor did not send any message (#22695 by @ericrosenthal)
VisitorClientInfo not showing (#22593)
🔍 Minor changes
[Fix] Omnichannel Real Time Monitoring charts not displaying all data (#22363)
[Fix] Real Time Monitoring charts - chats-per-agent and chats-per-department - not visible (#22406)
Bump actions/stale from 3.0.18 to 3.0.19 (#22060 by @dependabot[bot])
Bump glob-parent from 5.1.1 to 5.1.2 in /ee/server/services (#22328 by @dependabot[bot])
Bump: Fuselage 0.28.0 (#22822)
Chore: [Snyk] Security upgrade node-gcm from 0.14.4 to 1.0.0 (#22582 by @snyk-bot)
Chore: added pagination to search msg endpoint (#22632)
Chore: Create README.md (#22615)
Chore: Enable Omnicahnnel by default (#22697)
Chore: Meteor 2.2 and bump dependencies (#22399)
Chore: Remove JSON parse middleware (#22454)
Chore: Remove Sodium from the main client (#22459)
Chore: Review some dependencies (#22522)
Upgrade some development dependencies.
Chore: Support other pr titles (#22494)
Chore: Upgrade Micro Services NPM dependencies (#22561)
Chore: Upgrade NPM dependencies (#22562)
Chore: Use projection instead of fields to avoid error log (#22629)
Fix Closed chats doesn't shows who picked the call (#22368)
i18n: Language update from LingoHub 🤖 on 2021-06-28Z (#22491)
i18n: Language update from LingoHub 🤖 on 2021-07-05Z (#22572)
Merge master into develop & Set version to 3.17.0-develop (#22493)
Regression: Added missing translate keys for Federation (#22810)
Regression: Allow users to search canned responses based on shortcut or content (#22735)
Regression: Allow users to update canned responses scope (#22738)
Regression: Change the name of called methods in Users model (#22620)
Regression: Check for text before parse preview in create canned response form (#22754)
Regression: Client crashing on startup (#22610)
Regression: Create livechat-monitor permissions for Canned Responses (#22781)
Regression: Data in the "Active Users" section is delayed in 1 day (#22794)
Fix 1 day delay in the Engagement Dashboard's "Active Users" section;
Downgrade
![active-users-engagement-dashboard](https://user-images.githubusercontent.com/36537004/127372185-390dc42f-bc90-4841-a22b-731f0aafcafe.PNG)
@nivo/line
version.Expected behavior:
Regression: Data in the "New Users" section is delayed in 1 day (#22751)
Regression: Federation warnings on ci (#22765)
fix some linting warnings on federation modal
Regression: Filter of canned responses in contextual-bar (#22762)
Regression: fix canned responses filters for monitors (#22782)
Regression: Fix canned responses permissions for monitors & managers (#22793)
Regression: Fix ee microservices build (#22656)
Regression: Fix empty canned responses table when searching (#22743)
Regression: Fix empty tag field (#22767)
Regression: fix non ee tag field on canned responses (#22775)
Regression: fix outdated data on canned filters (#22766)
Regression: Fix tooltip style in the "Busiest Chat Times" chart (#22813)
Expected behavior:
![busiest-times-ed](https://user-images.githubusercontent.com/36537004/127527827-465397ed-f089-4fb7-9ab2-6fa8cea6abdf.PNG)
Regression: Fix users not being able to see the scope of the canned m… (#22760)
Regression: Fixes empty department field on edit canned responses (#22741)
This fixes the empty department field when editing a canned response via table on omnichannel menu. this also convert some of the files to TS that were created in js initially, also created/adjusted some types
Regression: Internal Error when saving files using GridFS (#22792)
Regression: observe-sequence version syntax broken on IE (#22557)
Regression: Parse canned responses placeholders (#22777)
Regression: Prevent custom status from being visible in sequential messages (#22733)
before
after
Regression: Properly force newline in attachment fields (#22727)
I've incorrectly enforcing the newline character in attachment fields, resulting in "<br />" text being rendered.
Regression: Remove Tags from canned response filter (#22779)
Regression: Replaced manual state control with a .once event (#22800)
Regression: Rocket.Chat crashes on startup if there's a Custom OAuth service configured (#22740)
Regression: roles.removeUserFromRole API not working with scoped roles. (#22799)
Regression: Small UI changes Federation (#22811)
Regression: Text wrap in MarkdownTextEditor and PreviewText (#22798)
Regression: Translate scope on canned responses dashboard (#22773)
Release 3.16.4 (#22815)
revert the lastMessage fix for visitor abandonment (#22720 by @ericrosenthal)
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓