Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Channel is automatically getting added to the first option in move to team feature #22670

Merged
merged 4 commits into from
Jul 21, 2021
Merged

[FIX] Channel is automatically getting added to the first option in move to team feature #22670

merged 4 commits into from
Jul 21, 2021

Conversation

ostjen
Copy link
Contributor

@ostjen ostjen commented Jul 14, 2021 •
edited by gabriellsh
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Enter a room
  • Open Room Info
  • Click on the kebab-menu (or if visible, directly on the Move to Team button)
  • Click the Move to Team button
  • The modal shouldn't allow to continue before selecting a team

Further comments

@ostjen ostjen requested a review from gabriellsh July 16, 2021 14:04
@ostjen ostjen requested a review from tassoevan July 20, 2021 14:46
@gabriellsh gabriellsh changed the title [FIX] WIP: Channel is automatically getting added to the first option in move to team feature [FIX] Channel is automatically getting added to the first option in move to team feature Jul 20, 2021
@ggazzo ggazzo merged commit 844110c into develop Jul 21, 2021
@ggazzo ggazzo deleted the moveToTeamFix branch July 21, 2021 03:50
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@gabriellsh gabriellsh Awaiting requested review from gabriellsh

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ostjen @dougfabris @ggazzo @gabriellsh