Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove stack traces from Meteor errors when debug setting is disabled #22699

Merged
merged 7 commits into from
Jul 20, 2021

Conversation

matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Fix 'not iterable' errors in the normalizeMessage function;
  • Remove stack traces from errors thrown by the jitsi:updateTimeout (and other Meteor.Errors) method.

Issue(s)

Task - ClickUp
Fixes #19441

Steps to test or reproduce

  1. Create a room and add a member to it;
  2. Members > select the added user > Mute User;
  3. Login as the muted user and start a Call in the new room;
  4. If the room is read-only, the following error will be thrown: server.js:204 System ➔ error Error starting video call: You can't send messages because the room is readonly.
    Otherwise, the thrown error will be: server.js:204 System ➔ error Error starting video call: You_have_been_muted (stack traces from Meteor.Error have been removed).
    The Meteor stack trace is still shown if the admin user chooses "2 - Errors, Information and Debug" in Administration > Logs > Log Level.

Further comments

@matheusbsilva137 matheusbsilva137 merged commit b96b062 into develop Jul 20, 2021
@matheusbsilva137 matheusbsilva137 deleted the remove-meteor-stack-traces branch July 20, 2021 23:39
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Some errors in RC logs looks like unhandled
2 participants