Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Support ID param on createVisitor method #22772

Merged
merged 4 commits into from
Jul 27, 2021

Conversation

murtaza98
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested review from KevLehman and d-gubert July 27, 2021 14:36
app/livechat/server/lib/Livechat.js Outdated Show resolved Hide resolved
app/livechat/server/lib/Livechat.js Show resolved Hide resolved
@d-gubert
Copy link
Member

LGTM! But since @KevLehman left some comments I'll leave the approval to him 😉

@KevLehman KevLehman merged commit 297b4e0 into develop Jul 27, 2021
@KevLehman KevLehman deleted the omnichannel/createVisitor-id-support branch July 27, 2021 19:07
gabriellsh added a commit that referenced this pull request Jul 27, 2021
…ile_upload

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Data in the "New Users" section is delayed in 1 day (#22751)
  [FIX] Support ID param on createVisitor method (#22772)
  Regression: fix non ee tag field on canned responses (#22775)
  [FIX] Blank screen in message auditing DM tab (#22763)
  Show translated scope on cr dashboard (#22773)
  Regression: Fix empty tag field (#22767)
  Regression: Federation warnings on ci (#22765)
  Regression: fix outdated data on canned filters (#22766)
  [IMPROVE] Return open room if available for visitors (#22742)
  Regression: Fix empty canned responses table when searching (#22743)
  Regression: Filter of canned responses in contextual-bar (#22762)
  Regression: Fix users not being able to see the scope of the canned message (#22760)
  Regression: Fixes empty department field on edit canned responses (#22741)
  Regression: Allow users to update canned responses scope (#22738)
  allow users to search canned responses based on shortcut or content (#22735)
  Regression: Check for text before parse preview in create canned response form (#22754)
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants