Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API's from react-native-blob-util #388

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

javache
Copy link

@javache javache commented Nov 22, 2024

TurboReactPackage and the deprecated ReactModuleInfo constructor will be removed from a future release. These classes are already present in recent React Native releases, so this makes react-native-blob-util compatible with future RN releases.

@trajano
Copy link

trajano commented Nov 25, 2024

I think this would be helpful for supporting Expo 52 with new architecture

@RonRadtke
Copy link
Owner

@javache hmm, unsure about that one. Checking the documentation: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/turbo-modules.md
It's still using TurboReactPackage

What would be the advantage?

@javache
Copy link
Author

javache commented Nov 27, 2024

Ah, good catch, that's out of date! TurboReactPackage was removed in facebook/react-native@bf5c98c

@RonRadtke
Copy link
Owner

Ah, good catch, that's out of date! TurboReactPackage was removed in facebook/react-native@bf5c98c

Thank you very much!
I can't find any information when it was deprecated. Just your PR (facebook/react-native#47680)
Do yu by any chance know if we need to adjsut the minimum RN verison?

I will also submit a PR to update the docs

@javache
Copy link
Author

javache commented Nov 28, 2024

I've already sent a PR for the docs :)

BaseReactPackage was introduced in facebook/react-native#40775 (Tue Oct 10 15:43:48 2023 -0700), the deprecated ReactModuleInfo constructor I've removed was changed in facebook/react-native#39459, so both should be available in 0.74.

@RonRadtke RonRadtke merged commit 07ac60c into RonRadtke:master Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants