deprecate hasConstants from ReactModuleInfo #39459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: 784b3b6311fe682e068e71a99d4497edcb3ec8b8
philIip
force-pushed
the
export-D49262824
branch
from
969866c to
fb4452b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: b2227359003eabdfbea0cc5cd8680e68c7e4e336
philIip
force-pushed
the
export-D49262824
branch
from
fb4452b to
5c9d942
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: f14f6fffd3e32fddd8906b925e6695963a3b35e9
philIip
force-pushed
the
export-D49262824
branch
from
5c9d942 to
45b4a9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: e1316521d63e05622a6ad6c4d347d8b4f120096d
philIip
force-pushed
the
export-D49262824
branch
from
45b4a9e to
20abf86
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: 4447402058d37cf663be0afeb9cb550e3a8956df
philIip
force-pushed
the
export-D49262824
branch
from
20abf86 to
bd65a06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39459 ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824 fbshipit-source-id: bf800895eef6e69dd3f938062723fbdd48cd9553
philIip
force-pushed
the
export-D49262824
branch
from
bd65a06 to
16b2a9c
Compare
Base commit: 4919741 |
philIip
force-pushed
the
export-D49262824
branch
from
16b2a9c to
d7b4870
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 16, 2023
Summary: ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 16, 2023
Summary: ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824
philIip
force-pushed
the
export-D49262824
branch
from
d7b4870 to
e173ca6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 16, 2023
Summary: ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824
philIip
force-pushed
the
export-D49262824
branch
from
e173ca6 to
163fdd4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
Summary: ## Changelog [Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss. Reviewed By: cortinico Differential Revision: D49262824
|
This pull request was exported from Phabricator. Differential Revision: D49262824 |
philIip
force-pushed
the
export-D49262824
branch
from
163fdd4 to
9567337
Compare
|
This pull request has been merged in 9f52378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[Android][Deprecated] - ReactModuleInfo constructor with getConstants arg is deprecated
introducing a new constructor that doesn't use getConstants and updating the internal codebase to use it. deprecated the old one since it's been copypasta'd a lot in oss.
Reviewed By: cortinico
Differential Revision: D49262824