Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new summary tab to dashboard #177

Merged
merged 6 commits into from
Jan 16, 2018
Merged

Conversation

sjanuary
Copy link
Contributor

@sjanuary sjanuary commented Jan 9, 2018

Includes update to graphmetrics 1.1.0

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #177 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   16.57%   16.43%   -0.14%     
==========================================
  Files           8        8              
  Lines        1943     1959      +16     
==========================================
  Hits          322      322              
- Misses       1621     1637      +16
Flag Coverage Δ
#SwiftBAMDC 0% <ø> (ø) ⬆️
#SwiftMetrics 16.43% <0%> (-0.14%) ⬇️
#SwiftMetricsBluemix 20.32% <ø> (ø) ⬆️
#SwiftMetricsDash 18.24% <0%> (-0.17%) ⬇️
#SwiftMetricsKitura 17.8% <0%> (-0.16%) ⬇️
#SwiftMetricsPrometheus 16.43% <0%> (-0.14%) ⬇️
Impacted Files Coverage Δ
Sources/SwiftMetricsDash/SwiftMetricsDash.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb6e72...fe2caae. Read the comment docs.

Copy link
Member

@mattcolegate mattcolegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, pulled and tested - summary tab comes up fine with good-looking data, came across issue where if you maximise the Environment pane, switch to the Dashboard tab then back to the Summary tab, the Environment pane is no longer central.

@sjanuary
Copy link
Contributor Author

Fixed tab-switch bug in graphmetrics -RuntimeTools/graphmetrics#46
Updated submodule again to point to latest graphmetrics

@mattcolegate
Copy link
Member

Change to graphmetrics fixes behaviour previously seen. Change approved so long as Travis builds

@mattcolegate mattcolegate merged commit 06a8947 into RuntimeTools:master Jan 16, 2018
@sjanuary sjanuary added this to the 2.2.0 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants