Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Encodable to JSON serialize objects in SwiftMetricsDash instead of SwiftyJSON" #179

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

sjanuary
Copy link
Contributor

@sjanuary sjanuary commented Jan 11, 2018

Reverts #174 for the time being due to clash with #177

@codecov-io
Copy link

Codecov Report

Merging #179 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   16.75%   16.57%   -0.19%     
==========================================
  Files           8        8              
  Lines        1922     1943      +21     
==========================================
  Hits          322      322              
- Misses       1600     1621      +21
Flag Coverage Δ
#SwiftBAMDC 0% <ø> (ø) ⬆️
#SwiftMetrics 16.57% <0%> (-0.19%) ⬇️
#SwiftMetricsBluemix 20.32% <ø> (ø) ⬆️
#SwiftMetricsDash 18.41% <0%> (-0.23%) ⬇️
#SwiftMetricsKitura 17.96% <0%> (-0.22%) ⬇️
#SwiftMetricsPrometheus 16.57% <0%> (-0.19%) ⬇️
Impacted Files Coverage Δ
Sources/SwiftMetrics/SwiftMetrics.swift 63.44% <ø> (ø) ⬆️
...wiftMetricsPrometheus/SwiftMetricsPrometheus.swift 0% <0%> (ø) ⬆️
...ources/SwiftMetricsKitura/SwiftMetricsKitura.swift 0% <0%> (ø) ⬆️
Sources/SwiftMetricsDash/SwiftMetricsDash.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a216368...f9d912e. Read the comment docs.

@sjanuary sjanuary requested a review from mattcolegate January 15, 2018 10:44
Copy link
Member

@mattcolegate mattcolegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds and sample apps run fine

@mattcolegate mattcolegate merged commit e83a30d into master Jan 15, 2018
@sjanuary sjanuary deleted the revert-174-swift4-encodable branch January 17, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants