[FEATURE] ProjectBuilder: Add outputStyle option to request flat build output
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
flat-build-output
branch
from
4a8f2f0 to
879f464
Compare
RandomByte
force-pushed
the
flat-build-output
branch
from
879f464 to
047307c
Compare
New option 'flatOutput'. If set to true, libraries and theme-libraries will omit the "/resources/<namespace>" directory structure in the build output.
RandomByte
force-pushed
the
flat-build-output
branch
from
047307c to
eaa70e6
Compare
RandomByte
commented
Nov 16, 2023
flovogt
reviewed
Nov 30, 2023
matz3
reviewed
Dec 4, 2023
RandomByte
commented
Dec 8, 2023
|
We should request a review from @KlattG once the texts are updated |
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
KlattG
suggested changes
Dec 11, 2023
| * @property {string} Default Default directory structure for every project type. | ||
| * For applications this is identical to "Flat" and for libraries to "Namespace". | ||
| * Other types have a more distinct default output style. | ||
| * @property {string} Flat Omits the project namespace and the "resources" directory. |
There was a problem hiding this comment.
These string variable names are in uppercase - do we have any guidelines which case to use?
There was a problem hiding this comment.
It's the same as the following module we already have: https://github.com/SAP/ui5-project/blob/main/lib/ui5Framework/maven/CacheMode.js
Basically, those are enums and they are expected to start with a capital letter. It's actually a workaround we use as JavaScript does not have native Enum type.
Co-authored-by: Günter Klatt <[email protected]>
d3xter666
added a commit
to SAP/ui5-cli
that referenced
this pull request
Dec 12, 2023
New CLI `build` option `--output-style`. Whether to omit the /resources/\<namespace\> directory structure in the build output. Resolves SAP/ui5-tooling#507 Depends on: SAP/ui5-project#624
|
LGTM |
matz3
approved these changes
Dec 12, 2023
|
Maybe adjust the PR title to mention the new |
d3xter666
changed the title
outputStyle option to request flat build output
KlattG
reviewed
Dec 12, 2023
| * @property {string} Default Default directory structure for every project type. | ||
| * For applications this is identical to "Flat" and for libraries to "Namespace". | ||
| * Other types have a more distinct default output style. | ||
| * @property {string} Flat Omits the project namespace and the "resources" directory. |
d3xter666
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Dec 14, 2023
Adds a section which describes the Build Output Styles feature and usage variants. Depends on: - SAP/ui5-project#624 - SAP/ui5-cli#665 --------- Co-authored-by: Günter Klatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
outputStyle. Whether to omit the/resources/<namespace>directory structure in the build output.Resolves SAP/ui5-tooling#507