-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui5 cli does not create source maps #472
Comments
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#472
Hi and thanks for opening this issue 👋 Generating source maps is on our internal backlog and the heavy work has already been done in However there are still some tricky questions on how to integrate this new build step in a well working and performant way. Also see https://github.com/SAP/ui5-builder/pull/282/files#r330896961 I am currently looking into refactoring parts of I'll leave this issue open so others can find it but I'll label it as a feature request 👍 PS: Please ignore PR 562 in the timeline above which mistakenly referenced this issue |
Resolves SAP/ui5-tooling#472 Supersedes #282 Based on SAP/ui5-tooling#583 JIRA: CPOUI5FOUNDATION-434 Co-authored-by: Matthias Osswald <[email protected]>
Implemented with SAP/ui5-builder#695 and available as of v3.0.0 Thanks a lot @matzetronic for bringing this topic up. |
Hi,
we want to create a ui5 library using ui5 cli. The library is created including minified files and -dbg.js files but no source maps are created.
Expected Behavior
A js.map file should be created for each source file and minified sources should have a source mapping url pointing to the not minified source (-dgb.js) files.
Current Behavior
No source maps are created during "ui5 build".
Steps to Reproduce the Issue
run "ui5 build" in a ui5 library and inspect the build result.
Context
ui5 --version
when using the CLI):2.6.6
10.22.0
6.14.6
Mac OS 10.15.7
unknown
nothing
The text was updated successfully, but these errors were encountered: