docs: new cem for Topic-P components - ShellBar (#7823)

* docs: new cem for Topic-P components - ShellBar Issue: #7610 * docs: new cem for Topic-P components - ShellBar - fixed review comments * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - ShellBar - fixed review comments * chore: update chromedriver to 119 (#7883) * fix(ui5-switch): align 'off' text in RTL, add compact mode params (#7603) In RTL mode the 'off' icon of `Graphical` type Switch was misaligned due to missing parameters for RTL scenario of the control. Fixes: #7522 Fixes: #7806 * fix(framework): redundant fonts loading (#7868) fix(framework): font loading Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - ShellBar - fixed review comments --------- Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]>
SAP · Nov 21, 2023 · 8d79551 · 8d79551
1 parent 7a3954f
commit 8d79551
Show file tree

Hide file tree

Showing 11 changed files with 96 additions and 170 deletions.
diff --git a/packages/base/package.json b/packages/base/package.json
@@ -38,7 +38,7 @@
     "@buxlabs/amd-to-es6": "0.16.1",
     "@openui5/sap.ui.core": "1.116.0",
     "@ui5/webcomponents-tools": "1.20.0-rc.1",
-    "chromedriver": "118.0.1",
+    "chromedriver": "119.0.1",
     "clean-css": "^5.2.2",
     "copy-and-watch": "^0.1.5",
     "cross-env": "^7.0.3",

diff --git a/packages/base/src/ManagedStyles.ts b/packages/base/src/ManagedStyles.ts
@@ -105,16 +105,18 @@ const updateStyle = (data: StyleData, name: string, value = "", theme?: string)
 	}
 };
 
-const hasStyle = (name: string, value = "") => {
+const hasStyle = (name: string, value = ""): boolean => {
 	if (shouldUseLinks()) {
 		return !!document.querySelector(`head>link[${name}="${value}"]`);
 	}
 
+	const styleElement = document.querySelector(`head>style[${name}="${value}"]`);
+
 	if (document.adoptedStyleSheets && !isSafari()) {
-		return !!document.adoptedStyleSheets.find(sh => (sh as Record<string, any>)._ui5StyleId === getStyleId(name, value));
+		return !!styleElement || !!document.adoptedStyleSheets.find(sh => (sh as Record<string, any>)._ui5StyleId === getStyleId(name, value));
 	}
 
-	return !!document.querySelector(`head>style[${name}="${value}"]`);
+	return !!styleElement;
 };
 
 const removeStyle = (name: string, value = "") => {

diff --git a/packages/fiori/package.json b/packages/fiori/package.json
@@ -49,6 +49,6 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "1.20.0-rc.1",
-    "chromedriver": "118.0.1"
+    "chromedriver": "119.0.1"
   }
 }
diff --git a/packages/fiori/src/Interfaces.ts b/packages/fiori/src/Interfaces.ts
@@ -61,15 +61,6 @@ const INotificationListItem = "sap.ui.webc.fiori.INotificationListItem";
  */
 const IProductSwitchItem = "sap.ui.webc.fiori.IProductSwitchItem";
 
-/**
- * Interface for components that may be slotted inside <code>ui5-shellbar</code> as items
- *
- * @name sap.ui.webc.fiori.IShellBarItem
- * @interface
- * @public
- */
-const IShellBarItem = "sap.ui.webc.fiori.IShellBarItem";
-
 /**
  * Interface for components that may be slotted inside <code>ui5-side-navigation</code> as items
  *
@@ -132,7 +123,6 @@ export {
 	INotificationAction,
 	INotificationListItem,
 	IProductSwitchItem,
-	IShellBarItem,
 	ISideNavigationItem,
 	ISideNavigationSubItem,
 	ISortItem,