[Switch]: Rendering issue with Horizon High Contrast Black Theme while :focus #7806
Closed
1 task done
Comments
|
Hello @SAP/ui5-webcomponents-topic-b, Please have a look. The issue is easily reproducible in Storybook. Best regards, |
nnaydenow
added a commit
that referenced
this issue
Nov 21, 2023
* docs: new cem for Topic-P components - ShellBar Issue: #7610 * docs: new cem for Topic-P components - ShellBar - fixed review comments * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - ShellBar - fixed review comments * chore: update chromedriver to 119 (#7883) * fix(ui5-switch): align 'off' text in RTL, add compact mode params (#7603) In RTL mode the 'off' icon of `Graphical` type Switch was misaligned due to missing parameters for RTL scenario of the control. Fixes: #7522 Fixes: #7806 * fix(framework): redundant fonts loading (#7868) fix(framework): font loading Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - ShellBar - fixed review comments --------- Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]>
nnaydenow
added a commit
that referenced
this issue
Jan 10, 2024
* docs: generate cem * chore: cleanup * chore: migrate button * chore: generate manifest for base * chore: cleanup * chore: enhance * chore: align storybook to use cem * chore: 09/10 * chore: 10.10 * chore: add validator for manifest * chore: add valid jsdoc tags * chore: improve validators * chore: migrate samples prepare to storybook * chore: ts * chore: fix missing tags * chore: clean * chore: correct deps * chore: fix scripts * chore: validate tags * chore: optional execution of script * chore: sampels docs * chore: restore previous scripts and enable cem for base * chore: fix validation of @default * chore: fix storybook build * chore: fix schema and add missing tags * chore: restore bundle * chore: add param type * chore: generate new manifest * fix: chore description * fix: param / unnamed slots privacy * chore: show css parts * chore: extract storybook * chore: restore nps script * chore: restore component migration * fix: default value * fix: enum schema validation * fix: show interfaces * fix: ts files path * chore: refacotor, fix validation, add internal json * chore: update schema and validation * chore: add yarnlock * chore: fix event param types * fix: show event params * fix: display only public ones * chore: restore input paths * chore: refactor * chore: update schema * chore: restore paths * chore: add override for getters, methods, props * docs: new cem for Topic-P components - Icon (#7810) * docs: new cem for Topic-P components - Icon Issue: #7610 * docs: new cem for Topic-P components - Icon -fixed review comments * docs: new cem for Topic-P components - Icon -ignored lint error * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - Icon -removed @INTERACE jsdoc tag from interfaces file --------- Co-authored-by: Ivaylo Plashkov <[email protected]> * docs: new cem for Topic-P components - ShellBar (#7823) * docs: new cem for Topic-P components - ShellBar Issue: #7610 * docs: new cem for Topic-P components - ShellBar - fixed review comments * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - ShellBar - fixed review comments * chore: update chromedriver to 119 (#7883) * fix(ui5-switch): align 'off' text in RTL, add compact mode params (#7603) In RTL mode the 'off' icon of `Graphical` type Switch was misaligned due to missing parameters for RTL scenario of the control. Fixes: #7522 Fixes: #7806 * fix(framework): redundant fonts loading (#7868) fix(framework): font loading Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - ShellBar - fixed review comments --------- Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> * chore: add privacy for shellbar events * chore: ehnance validator * chore: add storybook * chore: migrate base package * chore: add correct export definition * docs(ui5-rating-indicator): improve documentation (#7915) * docs(ui5-textarea): improve documentation (#7913) * fix(ui5-textarea): improve documentation * docs(ui5-textarea): reflect comments * chore: fix some components values and make storybook to work * docs(ui5-slider, ui5-range-slider): enhance documentation (#7910) * fix(ui5-slider, ui5-range-slider): enhance documentation * docs(ui5-slider, ui5-range-slider): reflect review comments * chore: cleanup * docs: new cem for Topic-P components - Toolbar (#7814) * docs: new cem for Topic-P components - Toolbar Issue: #7610 * docs: new cem for Topic-P components - Toolbar -refactored toolbar related files docs * docs: new cem for Topic-P components - Toolbar - removed unnecessary tag rom ToolbarSeparator docs * docs: new cem for Topic-P components - Toolbar -fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - List (#7824) * docs: new cem for Topic-P components - List Issue: #7610 * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * chore: fulfill list * docs(ui5-message-strip): improve documentation (#7917) * docs(ui5-message-strip): improve documentation * docs(ui5-message-strip): reflect review comments * docs(ui5-toast): improve documentation (#7914) * docs(ui5-toast): improve documentation * docs(ui5-toast): reflect review comments * docs: new cem for Topic-P components (#7851) * docs: new cem for Topic-P components (#7850) * docs: new cem for Topic-P components - ui5-select * docs: new cem for Topic-P components - ui5-select * docs: new cem for Topic-P components * docs: new cem for Topic-P components --------- Co-authored-by: Nayden Naydenov <[email protected]> * chore: fulfill * docs: new cem for Topic-P components - Tree (#7927) * fix(ui5-textarea): adjust scroll positioning (#7920) * docs(ui5-select-menu-option): correct disabled property description (#7925) docs(ui5-select-menu-option): correct docs Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - Tree Issue: #7610 * docs: new cem for Topic-P components - Tree -fixed review comments --------- Co-authored-by: niyap <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> * chore: fullfill * docs(ui5-panel): improve documentation (#7924) * docs(ui5-panel): improve documentation * docs(ui5-panel): reflect review comments * docs(ui5-panel): reflect review comments * docs(ui5-page): improve documentation (#7919) * docs: rewrite JSDoc for custom-elements-manifest/analyzer (#7778) * docs: new cem for Topic-RD components JSDoc changes related to using the new custom-elements-manifest for Rodopi-owned components. Issue: #7610 * docs: remove types from enums * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * chore: fulfill * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 --------- Co-authored-by: Nayden Naydenov <[email protected]> * chore: ts build * docs: Adapt JSDocs for new CЕM and Remove Redundancies (#7922) * docs: Adapt JSDocs for new CЕM and Remove Redundancies * docs: fix merge conflict * docs: adapt docs to updated specs * docs: fix storybook errors * docs: add missing file * docs: update interfaces * docs: fix comments * docs: fix more comments * docs: another comments fix * docs: fix more comments * docs: fix comments * docs: fix ITtimelineItem interface properties --------- Co-authored-by: Nayden Naydenov <[email protected]> * docs(ui5-wizard): improve documentation (#7935) * docs(ui5-wizard): improve documentation * docs(ui5-wizard): reflect review comments * docs(ui5-combobox): improve documentation (#7942) * chore: execute package script * chore: extract type of parameters with default and enhace storybook * docs(ui5-multi-combobox): improve documentation (#7944) * chore: fix missed files * chore: fixes * chore: fix superclass references * chore: fix paths * chore: align exports with modules name * chore: fix datepicker * chore: add _ui5validator * docs(ui5-table): improve documentation (#7951) * docs(ui5-table): improve documentation * docs(ui5-table): reflect review comments --------- Co-authored-by: Nia Peeva <[email protected]> * docs(ui5-input, ui5-multi-input): improve documentation (#7969) Co-authored-by: Nia Peeva <[email protected]> * chore: fixes * chore: update schema * chore: handle non metadata props * chore: fix select * fix tree * fix tree items * fix tree * review comments * chore: aling interfaces * cleanup interfaces * chore: tab container * chor: tab container interface * chore: return type of color palette popover * chore: fix tree test * escaped new lines * remove parts * optimizations * chore: fix pathds * chore: make some components private * fix schema validation and cleanup * ehance customElement decorator * customElement decorator * fix globs pattern * makr correctly custom elements * corrections * chore: 2 interfaces added * chore: 2 more fixes * chore: fix label and token * chore: do not sort props --------- Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Vladislav Tasev <[email protected]> Co-authored-by: Plamen Ivanov <[email protected]> Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: niyap <[email protected]> Co-authored-by: yanaminkova <[email protected]> Co-authored-by: Siyana Todorova <[email protected]> Co-authored-by: Nikolay Hristov <[email protected]> Co-authored-by: Nia Peeva <[email protected]>
PetyaMarkovaBogdanova
pushed a commit
that referenced
this issue
Jan 17, 2024
* docs: generate cem * chore: cleanup * chore: migrate button * chore: generate manifest for base * chore: cleanup * chore: enhance * chore: align storybook to use cem * chore: 09/10 * chore: 10.10 * chore: add validator for manifest * chore: add valid jsdoc tags * chore: improve validators * chore: migrate samples prepare to storybook * chore: ts * chore: fix missing tags * chore: clean * chore: correct deps * chore: fix scripts * chore: validate tags * chore: optional execution of script * chore: sampels docs * chore: restore previous scripts and enable cem for base * chore: fix validation of @default * chore: fix storybook build * chore: fix schema and add missing tags * chore: restore bundle * chore: add param type * chore: generate new manifest * fix: chore description * fix: param / unnamed slots privacy * chore: show css parts * chore: extract storybook * chore: restore nps script * chore: restore component migration * fix: default value * fix: enum schema validation * fix: show interfaces * fix: ts files path * chore: refacotor, fix validation, add internal json * chore: update schema and validation * chore: add yarnlock * chore: fix event param types * fix: show event params * fix: display only public ones * chore: restore input paths * chore: refactor * chore: update schema * chore: restore paths * chore: add override for getters, methods, props * docs: new cem for Topic-P components - Icon (#7810) * docs: new cem for Topic-P components - Icon Issue: #7610 * docs: new cem for Topic-P components - Icon -fixed review comments * docs: new cem for Topic-P components - Icon -ignored lint error * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - Icon -removed @INTERACE jsdoc tag from interfaces file --------- Co-authored-by: Ivaylo Plashkov <[email protected]> * docs: new cem for Topic-P components - ShellBar (#7823) * docs: new cem for Topic-P components - ShellBar Issue: #7610 * docs: new cem for Topic-P components - ShellBar - fixed review comments * fix(ui5-wizard): scrollbar styles are now present on root (#7838) * docs: new cem for Topic-P components - ShellBar - fixed review comments * chore: update chromedriver to 119 (#7883) * fix(ui5-switch): align 'off' text in RTL, add compact mode params (#7603) In RTL mode the 'off' icon of `Graphical` type Switch was misaligned due to missing parameters for RTL scenario of the control. Fixes: #7522 Fixes: #7806 * fix(framework): redundant fonts loading (#7868) fix(framework): font loading Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - ShellBar - fixed review comments --------- Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> * chore: add privacy for shellbar events * chore: ehnance validator * chore: add storybook * chore: migrate base package * chore: add correct export definition * docs(ui5-rating-indicator): improve documentation (#7915) * docs(ui5-textarea): improve documentation (#7913) * fix(ui5-textarea): improve documentation * docs(ui5-textarea): reflect comments * chore: fix some components values and make storybook to work * docs(ui5-slider, ui5-range-slider): enhance documentation (#7910) * fix(ui5-slider, ui5-range-slider): enhance documentation * docs(ui5-slider, ui5-range-slider): reflect review comments * chore: cleanup * docs: new cem for Topic-P components - Toolbar (#7814) * docs: new cem for Topic-P components - Toolbar Issue: #7610 * docs: new cem for Topic-P components - Toolbar -refactored toolbar related files docs * docs: new cem for Topic-P components - Toolbar - removed unnecessary tag rom ToolbarSeparator docs * docs: new cem for Topic-P components - Toolbar -fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - List (#7824) * docs: new cem for Topic-P components - List Issue: #7610 * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * chore: fulfill list * docs(ui5-message-strip): improve documentation (#7917) * docs(ui5-message-strip): improve documentation * docs(ui5-message-strip): reflect review comments * docs(ui5-toast): improve documentation (#7914) * docs(ui5-toast): improve documentation * docs(ui5-toast): reflect review comments * docs: new cem for Topic-P components (#7851) * docs: new cem for Topic-P components (#7850) * docs: new cem for Topic-P components - ui5-select * docs: new cem for Topic-P components - ui5-select * docs: new cem for Topic-P components * docs: new cem for Topic-P components --------- Co-authored-by: Nayden Naydenov <[email protected]> * chore: fulfill * docs: new cem for Topic-P components - Tree (#7927) * fix(ui5-textarea): adjust scroll positioning (#7920) * docs(ui5-select-menu-option): correct disabled property description (#7925) docs(ui5-select-menu-option): correct docs Co-authored-by: Nayden Naydenov <[email protected]> * docs: new cem for Topic-P components - Tree Issue: #7610 * docs: new cem for Topic-P components - Tree -fixed review comments --------- Co-authored-by: niyap <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Nayden Naydenov <[email protected]> * chore: fullfill * docs(ui5-panel): improve documentation (#7924) * docs(ui5-panel): improve documentation * docs(ui5-panel): reflect review comments * docs(ui5-panel): reflect review comments * docs(ui5-page): improve documentation (#7919) * docs: rewrite JSDoc for custom-elements-manifest/analyzer (#7778) * docs: new cem for Topic-RD components JSDoc changes related to using the new custom-elements-manifest for Rodopi-owned components. Issue: #7610 * docs: remove types from enums * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 * chore: fulfill * docs: rewrite JSDoc for custom-elements-manifest/analyzer Related to: #7610 --------- Co-authored-by: Nayden Naydenov <[email protected]> * chore: ts build * docs: Adapt JSDocs for new CЕM and Remove Redundancies (#7922) * docs: Adapt JSDocs for new CЕM and Remove Redundancies * docs: fix merge conflict * docs: adapt docs to updated specs * docs: fix storybook errors * docs: add missing file * docs: update interfaces * docs: fix comments * docs: fix more comments * docs: another comments fix * docs: fix more comments * docs: fix comments * docs: fix ITtimelineItem interface properties --------- Co-authored-by: Nayden Naydenov <[email protected]> * docs(ui5-wizard): improve documentation (#7935) * docs(ui5-wizard): improve documentation * docs(ui5-wizard): reflect review comments * docs(ui5-combobox): improve documentation (#7942) * chore: execute package script * chore: extract type of parameters with default and enhace storybook * docs(ui5-multi-combobox): improve documentation (#7944) * chore: fix missed files * chore: fixes * chore: fix superclass references * chore: fix paths * chore: align exports with modules name * chore: fix datepicker * chore: add _ui5validator * docs(ui5-table): improve documentation (#7951) * docs(ui5-table): improve documentation * docs(ui5-table): reflect review comments --------- Co-authored-by: Nia Peeva <[email protected]> * docs(ui5-input, ui5-multi-input): improve documentation (#7969) Co-authored-by: Nia Peeva <[email protected]> * chore: fixes * chore: update schema * chore: handle non metadata props * chore: fix select * fix tree * fix tree items * fix tree * review comments * chore: aling interfaces * cleanup interfaces * chore: tab container * chor: tab container interface * chore: return type of color palette popover * chore: fix tree test * escaped new lines * remove parts * optimizations * chore: fix pathds * chore: make some components private * fix schema validation and cleanup * ehance customElement decorator * customElement decorator * fix globs pattern * makr correctly custom elements * corrections * chore: 2 interfaces added * chore: 2 more fixes * chore: fix label and token * chore: do not sort props --------- Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: Vladislav Tasev <[email protected]> Co-authored-by: Plamen Ivanov <[email protected]> Co-authored-by: Ivaylo Plashkov <[email protected]> Co-authored-by: ilhan orhan <[email protected]> Co-authored-by: Stoyan <[email protected]> Co-authored-by: niyap <[email protected]> Co-authored-by: yanaminkova <[email protected]> Co-authored-by: Siyana Todorova <[email protected]> Co-authored-by: Nikolay Hristov <[email protected]> Co-authored-by: Nia Peeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
Issue with ui5-switch component, with Horizon High Contrast Black Theme while :focus :
The white line should be around the Switch:
Affected Component
ui5-switch
Expected Behaviour
The white line should be around the Switch while focusing the switch :
Isolated Example
https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-switch--docs&globals=theme:Horizon+High+Contrast+Black
Steps to Reproduce
...
Log Output, Stack Trace or Screenshots
Priority
Low
UI5 Web Components Version
1.19.0
Browser
Chrome
Operating System
Windows 11
Additional Context
No response
Organization
SAP
Declaration
The text was updated successfully, but these errors were encountered: