Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabContainer: implement responsive paddings #2539

Closed
ilhan007 opened this issue Dec 2, 2020 · 1 comment · Fixed by #2775
Closed

TabContainer: implement responsive paddings #2539

ilhan007 opened this issue Dec 2, 2020 · 1 comment · Fixed by #2775

Comments

@ilhan007
Copy link
Member

ilhan007 commented Dec 2, 2020

Is your feature request related to a problem? Please describe.
Support different paddings in the TabContainer, depending on the component size (not screen size).

Screenshot 2020-12-02 at 10 24 48 AM

Left and right margins of the tabstrip (the tabs area) and the content area (below the tabs) should follow the global layout paddings:

S: 1rem; (results in 16px); M: 2rem; L: 2rem; XL: 3rem; XXL: 3rem;
Size S | <= 599px
Size M | >=600px and <= 1023px
Size L | >= 1024px and <= 1439px
Size XL | >= 1440px

Describe the solution you'd like

A private property (could be "size" or similar) that tracks the component size + CSS that is applied accordingly.
The property can be updated in the existing resize handler "_handleHeaderResize".

:host([size="M"])  {
	padding: 0 2rem;
}
:host([size="L"]) {
	padding: 0 2rem;
}
:host([size="XL"])  {
	padding: 3rem;
}

Note: The tabstrip area may require some DOM/CSS refactoring - it is not just changing few paddings.

@ilhan007
Copy link
Member Author

ilhan007 commented Dec 2, 2020

FYI @SAP/ui5-webcomponents-topic-rd

@ilhan007 ilhan007 changed the title TabContainer: TabContainer: support responsive paddings Dec 2, 2020
@ilhan007 ilhan007 changed the title TabContainer: support responsive paddings TabContainer: implement responsive paddings Dec 2, 2020
@ilhan007 ilhan007 added the approved This issue is approved label Jan 11, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 3, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 4, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 4, 2021
@ilhan007 ilhan007 added this to the 1.0.0-rc.13 milestone Feb 4, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 5, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 9, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 9, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
TeodorTaushanov added a commit to TeodorTaushanov/ui5-webcomponents that referenced this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants