Skip to content

Commit

Permalink
feat(ui5-tabcontainer): Responsive paddings are now supported
Browse files Browse the repository at this point in the history
Fixes: SAP#2539
  • Loading branch information
TeodorTaushanov committed Feb 17, 2021
1 parent 578cef4 commit f24b408
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions packages/main/test/specs/TabContainer.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ describe("TabContainer general interaction", () => {
it("scroll works on iconsOnly TabContainer", () => {
browser.setWindowSize(520, 1080);

const arrowLeft = $("#tabContainerIconOnly").shadow$(".ui5-tc__headerArrowLeft");
const arrowRight = $("#tabContainerIconOnly").shadow$(".ui5-tc__headerArrowRight");
const arrowLeft = $("#tabContainerIconOnly").shadow$(".ui5-tc__headerArrowLeft ui5-button");
const arrowRight = $("#tabContainerIconOnly").shadow$(".ui5-tc__headerArrowRight ui5-button");

assert.ok(!arrowLeft.isDisplayed(), "'Left Arrow' should be initially hidden");
assert.ok(arrowRight.isDisplayed(), "'Right Arrow' should be initially shown");
Expand All @@ -51,11 +51,11 @@ describe("TabContainer general interaction", () => {
it("scroll works on textOnly TabContainer", () => {
browser.setWindowSize(520, 1080);

let arrowLeft = browser.$("#tabContainerTextOnly").shadow$(".ui5-tc__headerArrowLeft");
let arrowRight = browser.$("#tabContainerTextOnly").shadow$(".ui5-tc__headerArrowRight");
let arrowLeft = browser.$("#tabContainerTextOnly").shadow$(".ui5-tc__headerArrowLeft ui5-button");
let arrowRight = browser.$("#tabContainerTextOnly").shadow$(".ui5-tc__headerArrowRight ui5-button");

assert.ok(!arrowLeft.shadow$("svg").isDisplayed(), "'Left Arrow' should be initially hidden");
assert.ok(arrowRight.shadow$("svg").isDisplayed(), "'Right Arrow' should be initially shown");
assert.ok(!arrowLeft.isDisplayed(), "'Left Arrow' should be initially hidden");
assert.ok(arrowRight.isDisplayed(), "'Right Arrow' should be initially shown");

arrowRight.click();
browser.pause(1000); // TODO: wait for animation finish. Remove when solved on framework level
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2080,7 +2080,7 @@ chrome-launcher@^0.13.1:
mkdirp "^0.5.3"
rimraf "^3.0.2"

[email protected]:
[email protected], chromedriver@^88.0.0:
version "88.0.0"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-88.0.0.tgz#6833fffd516db23c811eeafa1ee1069b5a12fd2f"
integrity sha512-EE8rXh7mikxk3VWKjUsz0KCUX8d3HkQ4HgMNJhWrWjzju12dKPPVHO9MY+YaAI5ryXrXGNf0Y4HcNKgW36P/CA==
Expand Down

0 comments on commit f24b408

Please sign in to comment.