Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: Behavior improvement #3136

Closed
sleric1024 opened this issue Apr 13, 2021 · 5 comments · Fixed by #3174
Closed

Carousel: Behavior improvement #3136

sleric1024 opened this issue Apr 13, 2021 · 5 comments · Fixed by #3174
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD

Comments

@sleric1024
Copy link

Describe the bug
Some behavior are not the same as UI5 Carousel control

Isolated Example
https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-carousel--default-story

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-carousel--default-story

Expected behavior
Expect the same behavior as UI5

  1. When mouse move out of the carousel area, the navigation button should be hidden.
  2. Padding of navigation button suppose to be the same as UI5 Carousel control
  3. Need property support to hide the pagination.
    https://sapui5.hana.ondemand.com/#/entity/sap.m.Carousel/sample/sap.m.sample.CarouselWithDisplayOptions

Screenshots
image

UI5 Web Components for React Information
@ui5/webcomponents version: Currently Version
@ui5/webcomponents-react version: Currently Version
Operating System: Mac OS
Browser: Chrome

Additional context
I am from SuccessFactors, and current we are using Carousel to build project feature while the behavior are not the same as UI5 control.

@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Apr 13, 2021
@MapTo0 MapTo0 added bug This issue is a bug in the code TOPIC RD labels Apr 13, 2021
@ilhan007
Copy link
Member

Hi @sleric1024 could you extract the feature request from the issues and file it as separate GitHub issue
and update the current one keeping the issues only.

Entries 1 and 2 are issues:

  1. When mouse move out of the carousel area, the navigation button should be hidden.
  2. Padding of navigation button suppose to be the same as UI5 Carousel control

while the 3rd entry is a feature request:

  1. Need property support to hide the pagination.
    https://sapui5.hana.ondemand.com/#/entity/sap.m.Carousel/sample/sap.m.sample.CarouselWithDisplayOptions

@ilhan007
Copy link
Member

ilhan007 commented Apr 14, 2021

Hi @SAP/ui5-webcomponents-topic-rd could you check these two issues (the 3rd entry, if not removed, is a feature request and will be filed separately, so focus on these two):

  1. When mouse move out of the carousel area, the navigation button should be hidden.
  2. Padding of navigation button suppose to be the same as UI5 Carousel control
  • You will find details in the issue description
  • Consider the version of UI5 Web Components as "master"

@sleric1024
Copy link
Author

@ilhan007, thank you for your information.
Please refer to the 3rd one as a feature request #3158
Best Regards,
Eric

kskondov added a commit that referenced this issue Apr 22, 2021
kskondov added a commit that referenced this issue Apr 22, 2021
Arrows are hidden by default. Added noAtribute: true.

Fixes #3136
kskondov added a commit that referenced this issue Apr 22, 2021
Added since tag. Modified tests. Renamed showNavigationArrows

Fixes #3136
@ilhan007
Copy link
Member

Hello @sleric1024 The fix is released with 0.29.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants