Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: Need property support to hide the pagination #3158

Closed
sleric1024 opened this issue Apr 16, 2021 · 2 comments · Fixed by #3268
Closed

Carousel: Need property support to hide the pagination #3158

sleric1024 opened this issue Apr 16, 2021 · 2 comments · Fixed by #3268
Assignees
@georgimkv
Labels
feature request High Prio Planned SAP SF TOPIC RD
Milestone
1.0.0-rc.15

Comments

@sleric1024
Copy link

Is your feature request related to a problem? Please describe.
Feature request separated from issue #3136

Describe the solution you'd like
Need property to support hiding the pagination indicator.

image

Feature Request from SuccessFactors.
@sleric1024 sleric1024 mentioned this issue Apr 16, 2021
Closed
@MapTo0 MapTo0 added approved This issue is approved enhancement New feature or request TOPIC P labels Apr 16, 2021
@MapTo0
Copy link
Member

MapTo0 commented Apr 16, 2021

Dear Colleagues,

This is a feature request for adding showPageIndicator like property to the carousel.

Regards,
Martin
Github Dispatcher

@MapTo0 MapTo0 added feature request and removed TOPIC P approved This issue is approved enhancement New feature or request labels Apr 16, 2021
@ilhan007
Copy link
Member

ilhan007 commented Apr 16, 2021 •
edited
Loading

Hello @SAP/ui5-webcomponents-topic-rd

this is a feature request for an API to show/hide the page indicator of the Carousel. We would like to display it by default, so we would have to name the property hidePageIndicator.

Currently there is hide-navigation that hides both navigation arrows and page indicator, perhaps we have to divide it to hide-navigation only hiding the arrows and hide-page-indicator - the page indicator.

@ilhan007 ilhan007 added this to the 1.0.0-rc.16 milestone Apr 26, 2021
@georgimkv georgimkv self-assigned this May 17, 2021
@georgimkv georgimkv mentioned this issue May 18, 2021
Merged
ilhan007 pushed a commit that referenced this issue May 31, 2021
@georgimkv
feat(ui5-carousel): add property hide-page-indicator (#3268)
e13a4c9 
The page indicator can now be hidden by setting the property `hide-page-indicator` on the ui5-carousel element.

Closes: #3158
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.16, 1.0.0-rc.15 Aug 18, 2021
@petyabegovska petyabegovska moved this to 1.0.0-rc.15 (released Aug) in UI5 Web Components - Roadmap Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
feature request High Prio Planned SAP SF TOPIC RD
Projects
UI5 Web Components - Roadmap
Status: 1.0.0-rc.15 (released Aug)
Milestone
1.0.0-rc.15
Development

Successfully merging a pull request may close this issue.

feat(ui5-carousel): add property hide-page-indicator SAP/ui5-webcomponents
4 participants
@sleric1024 @MapTo0 @ilhan007 @georgimkv