Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][ComboBox with grouping][Urgent - WithIn 3 Weeks] support comboBox with grouping #3371

Closed
sfsf-xweb-sh opened this issue Jun 2, 2021 · 6 comments · Fixed by #3469
Closed

[SF][ComboBox with grouping][Urgent - WithIn 3 Weeks] support comboBox with grouping #3371

sfsf-xweb-sh opened this issue Jun 2, 2021 · 6 comments · Fixed by #3469
Assignees
@ndeshev
Labels
feature request High Prio Planned SAP SF
Milestone
1.0.0-rc.16

Comments

@sfsf-xweb-sh
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.

support comboBox with grouping

Screen Shot 2021-06-02 at 10 16 45 AM

We can refer to this page: https://sapui5.hana.ondemand.com/#/entity/sap.m.ComboBox/sample/sap.m.sample.ComboBoxGrouping
@dobrinyonkov dobrinyonkov self-assigned this Jun 2, 2021
@dobrinyonkov dobrinyonkov removed their assignment Jun 2, 2021
@ilhan007 ilhan007 added the SAP SF label Jun 2, 2021
@ilhan007
Copy link
Member

ilhan007 commented Jun 2, 2021

FYI, new feature request for the ComboBox @SAP/ui5-webcomponents-topic-rl

@ilhan007 ilhan007 added this to the 1.0.0-rc.17 milestone Jun 2, 2021
@sfsf-xweb-sh
Copy link
Author

sfsf-xweb-sh commented Jun 8, 2021 •
edited
Loading

Hi @ilhan007

Is there a timeline for this component ?
Can this component be finished in 3 weeks ?

@sfsf-xweb-sh sfsf-xweb-sh changed the title [SF][ComboBox with grouping] support comboBox with grouping [SF][ComboBox with grouping][Urgent - WithIn 3 Weeks] support comboBox with grouping Jun 8, 2021
@nikolay-kolarov
Copy link

Hello @sfsf-xweb-sh,

We have planned to start the work on the feature for the current sprint and we will keep you up to date on the execution.

Best Regards,
Nikolay

@fifoosid fifoosid mentioned this issue Jun 28, 2021
Merged
ilhan007 pushed a commit that referenced this issue Jul 1, 2021
@ndeshev
feat(ui5-combobox): add suggestions grouping (#3469)
5e3f391 
Enable users to set items to groups. Groups are visually identified in the suggestions list by group headers.
For group headers a new component is introduced - ComboBoxGroupItem. The grouping is based on the items order as they are declared in the markup - the items between two group headers are considered to belong to the first one.

Fixes: #3371
@ndeshev
Copy link
Contributor

ndeshev commented Jul 1, 2021

Hello,
The requested functionality is implemented and merged with #3469

Kind Regards,
Nikolay

@sfsf-xweb-sh
Copy link
Author

Hello,
The requested functionality is implemented and merged with #3469

Kind Regards,
Nikolay

Hello @sfsf-xweb-sh,

We have planned to start the work on the feature for the current sprint and we will keep you up to date on the execution.

Best Regards,
Nikolay

Thanks very much

ilhan007 pushed a commit that referenced this issue Jul 2, 2021
@ndeshev @ilhan007
feat(ui5-combobox): add suggestions grouping (#3469)
31f7c14 
Enable users to set items to groups. Groups are visually identified in the suggestions list by group headers.
For group headers a new component is introduced - ComboBoxGroupItem. The grouping is based on the items order as they are declared in the markup - the items between two group headers are considered to belong to the first one.

Fixes: #3371
@ilhan007
Copy link
Member

ilhan007 commented Jul 2, 2021

Hello @sfsf-xweb-sh released with 0.31.12

@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.17, 1.0.0-rc.16 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndeshev ndeshev

Labels
feature request High Prio Planned SAP SF
Projects
None yet
Milestone
1.0.0-rc.16
Development

Successfully merging a pull request may close this issue.

feat(ui5-combobox): add suggestions grouping ndeshev/ui5-webcomponents
5 participants
@ndeshev @ilhan007 @nikolay-kolarov @dobrinyonkov @sfsf-xweb-sh